Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added map method to query builders #45

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

akorchyn
Copy link
Collaborator

@akorchyn akorchyn commented Jan 30, 2025

  • added map method to change the query result type if you want to construct it some other way around. These methods help to simplify mapping internally (more clean) and provide a big improvement in dev UX on fetching data.

  • Bug-fixed Delegation::view_balance method that returned staked balance instead of unstaked.

@race-of-sloths

@race-of-sloths
Copy link

@akorchyn Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
We are launching a survey "Who is faster? You vs SpaceX"

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: waiting for scoring

We're waiting for maintainer to score this pull request with @race-of-sloths score [0,1,2,3,5,8,13] command. Alternatively, autoscoring [1,2] will be applied for this pull request

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@akorchyn akorchyn changed the title feat: added read_only_with_postprocess method to simplify contract interaction feat: added map method to query builders Feb 3, 2025
Copy link
Collaborator

@dj8yfo dj8yfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this thingy here has to test the same thing that will be published
RUSTDOCFLAGS="-D warnings" cargo doc --all-features --document-private-items

https://github.com/near/near-api-rs/blob/main/.github/workflows/test.yml#L43

@akorchyn
Copy link
Collaborator Author

this thingy here has to test the same thing that will be published RUSTDOCFLAGS="-D warnings" cargo doc --all-features --document-private-items

https://github.com/near/near-api-rs/blob/main/.github/workflows/test.yml#L43

Don't think it related to this PR, though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants