Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace and remove dependencies with lighter and audited alternatives #1224

Merged
merged 10 commits into from
Jan 3, 2024

Conversation

gtsonevv
Copy link
Collaborator

@gtsonevv gtsonevv commented Dec 21, 2023

Pre-flight checklist

  • I have read the Contributing Guidelines on pull requests.
  • Commit messages follow the conventional commits spec
  • If this is a code change: I have written unit tests.
  • If this changes code in a published package: I have run pnpm changeset to create a changeset JSON document appropriate for this change.
  • If this is a new API or substantial change: the PR has an accompanying issue (closes #0000) and the maintainers have approved on my working plan.

Motivation

Reuse noble-hashes instead of js-sha256 to reduce the amount of dependencies.
Reuse noble-curves instead of elliptic to reduce the amount of dependencies.
Remove error-polyfill package since it is no longer used explicitly.

Test Plan

All tests pass

Related issues/PRs

#1217
#1200

@gtsonevv gtsonevv requested a review from vikinatora December 21, 2023 13:29
Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: b1e9d9c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
@near-js/biometric-ed25519 Minor
@near-js/crypto Minor
@near-js/signers Minor
@near-js/transactions Minor
@near-js/accounts Patch
@near-js/keystores-browser Patch
@near-js/keystores-node Patch
@near-js/keystores Patch
near-api-js Patch
@near-js/wallet-account Patch
@near-js/cookbook Patch
@near-js/providers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

packages/signers/package.json Outdated Show resolved Hide resolved
packages/transactions/package.json Outdated Show resolved Hide resolved
packages/near-api-js/src/browser-index.ts Show resolved Hide resolved
@gtsonevv gtsonevv changed the title Remove buggy dependencies Reduce amount of dependencies Dec 21, 2023
@gtsonevv gtsonevv changed the title Reduce amount of dependencies Replace and remove dependencies with lighter and audited alternatives Dec 21, 2023
vikinatora
vikinatora previously approved these changes Dec 21, 2023
@gtsonevv gtsonevv requested review from frol and gagdiez December 21, 2023 15:10
gagdiez
gagdiez previously approved these changes Jan 2, 2024
@gtsonevv gtsonevv dismissed stale reviews from gagdiez and vikinatora via b1e9d9c January 3, 2024 07:23
@gtsonevv gtsonevv requested a review from vikinatora January 3, 2024 08:25
@gtsonevv gtsonevv merged commit db20bf5 into near:master Jan 3, 2024
5 checks passed
@gtsonevv gtsonevv deleted the remove-buggy-dependencies branch January 3, 2024 08:25
This was referenced Jan 3, 2024
@vikinatora vikinatora mentioned this pull request Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants