Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change .github/workflows of cargo near new project (interactive build choice) #264

Merged

Conversation

@dj8yfo dj8yfo mentioned this pull request Dec 9, 2024
8 tasks
@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Dec 9, 2024

diff -r old/.github/workflows/deploy-production.yml new/.github/workflows/deploy-production.yml
21c21
<           cargo near deploy "${{ vars.NEAR_CONTRACT_PRODUCTION_ACCOUNT_ID }}" \
---
>           cargo near deploy build-reproducible-wasm "${{ vars.NEAR_CONTRACT_PRODUCTION_ACCOUNT_ID }}" \
diff -r old/.github/workflows/deploy-staging.yml new/.github/workflows/deploy-staging.yml
44c44
<           cargo near deploy --skip-git-remote-check "${{ env.NEAR_CONTRACT_PR_STAGING_ACCOUNT_ID }}" \
---
>           cargo near deploy build-reproducible-wasm --skip-git-remote-check "${{ env.NEAR_CONTRACT_PR_STAGING_ACCOUNT_ID }}" \

@dj8yfo
Copy link
Collaborator Author

dj8yfo commented Dec 9, 2024

@race-of-sloths include

@race-of-sloths
Copy link

race-of-sloths commented Dec 9, 2024

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

Your contribution is much appreciated with a final score of 2!
You have received 23 (20 base + 15% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@dj8yfo dj8yfo changed the title chore: change .github/workflows of project, created by cargo near new chore: change .github/workflows of cargo near new project (interactive build choice) Dec 9, 2024
@dj8yfo dj8yfo marked this pull request as ready for review December 9, 2024 22:35
Copy link
Contributor

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 2

@frol frol merged commit 4988f5f into if-reproducible-interactive Dec 9, 2024
17 checks passed
@frol frol deleted the fix-workflows-reproducible-interactive branch December 9, 2024 23:22
dj8yfo added a commit that referenced this pull request Dec 17, 2024
this will look now like the following
```bash
❯ : cargo near build non-reproducible-wasm --help
Runs on current filesystem state without many restrictions
                                                                                                                                                             
Usage: cargo-near near build non-reproducible-wasm [OPTIONS]
                                                                                                                                                             
Options:
      --locked
      --no-release
      --no-abi
      --no-embed-abi
      --no-doc
      --no-wasmopt
      --out-dir <OUT_DIR>
      --manifest-path <MANIFEST_PATH>
      --features <FEATURES>
      --no-default-features
      --color <COLOR>                  [possible values: auto, always, never]
      --env <ENV>
  -h, --help                           Print help
  -V, --version                        Print version

```
```bash
❯ : cargo near build reproducible-wasm --help
Requires `docker` config added and (git)committed to Cargo.toml, runs on clean (git)working tree state
                                                                                                                                                             
Usage: cargo-near near build reproducible-wasm [OPTIONS]
                                                                                                                                                             
Options:
      --no-locked
      --out-dir <OUT_DIR>
      --manifest-path <MANIFEST_PATH>
      --color <COLOR>                  [possible values: auto, always, never]
  -h, --help                           Print help
  -V, --version                        Print version
```
---

this is pending 
- [x] deploy cmd dispatch in current pr
- [x] logic to enforce correct `container_build_command` for newer
images (ones, that will be built after release of this pr)
- [x] prettier indents in interactive help msgs in current pr
- [x] separate pr onto current pr as base branch with tests fixed as per
api change (#263)
- [x] testing of this pr on a few common cases (sample-crate,
factory-rust, neardevhub-contract) (in comment
#262 (comment))
- [x] separate pr onto current pr as base branch with
`.github/workflows` change /testing (#264)
- [x] separate pr onto current pr as base branch with docs/README update
(#265)
- [ ] merge

---------

Co-authored-by: dj8yf0μl <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants