feat(slice): remove ngrx immer dependency

nartc · Sep 27, 2022 · 01c6687 · 01c6687
1 parent 3405b98
commit 01c6687
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 21 deletions.
diff --git a/packages/ngrx-slice/README.md b/packages/ngrx-slice/README.md
@@ -16,24 +16,14 @@ yarn add ngrx-slice
 
 ### Peer Dependencies
 
-`ngrx-slice` has `ngrx-immer` and `immer` as its `peerDependencies` so go ahead and install those:
+`ngrx-slice` has `immer` as its `peerDependencies` so go ahead and install it:
 
 ```shell
-npm install ngrx-immer immer
+npm install immer
 ```
 
 ```shell
-yarn add ngrx-immer immer
-```
-
-Here's one command for all three:
-
-```shell
-npm install ngrx-slice ngrx-immer immer
-```
-
-```shell
-yarn add ngrx-slice ngrx-immer immer
+yarn add immer
 ```
 
 ## Documentations

diff --git a/packages/ngrx-slice/src/lib/create-slice-reducer.spec.ts b/packages/ngrx-slice/src/lib/create-slice-reducer.spec.ts
@@ -6,8 +6,6 @@ const initialState = {
   foo: 1,
 };
 
-const getter = (featureName: string, actionName: string) =>
-  `${featureName}/${actionName}`;
 
 const actions = {
   increment: createAction('foo/increment'),
@@ -22,7 +20,6 @@ describe(createSliceReducer.name, () => {
   beforeEach(() => {
     reducer = createSliceReducer(
       initialState,
-      getter,
       actions as any,
       {
         increment: (state) => {
@@ -33,7 +30,7 @@ describe(createSliceReducer.name, () => {
         },
       },
       [
-        on<typeof initialState, [typeof double]>(double, (state) => ({
+        on(double, (state) => ({
           ...state,
           foo: state.foo * 2,
         })),

diff --git a/packages/ngrx-slice/src/lib/create-slice-reducer.ts b/packages/ngrx-slice/src/lib/create-slice-reducer.ts
@@ -15,7 +15,6 @@ export function createSliceReducer<
   CaseReducers extends SliceCaseReducers<SliceState> = SliceCaseReducers<SliceState>
 >(
   initialState: SliceState,
-  sliceActionNameGetter: SliceActionNameGetter,
   actions: SliceActions<SliceState, CaseReducers>,
   reducers: CaseReducers,
   extraReducers?: SliceOptions<

diff --git a/packages/ngrx-slice/src/lib/create-slice.ts b/packages/ngrx-slice/src/lib/create-slice.ts
@@ -1,4 +1,4 @@
-import { createFeatureSelector } from '@ngrx/store';
+import {createFeatureSelector, ActionCreator} from '@ngrx/store';
 import type { Draft } from 'immer';
 import { createSliceActions } from './create-slice-actions';
 import { createSliceReducer } from './create-slice-reducer';
@@ -57,12 +57,11 @@ export function createSlice<
     name,
     sliceActionNameGetter,
     reducers,
-    reducersToActions,
+    reducersToActions
   );
 
   const reducer = createSliceReducer<SliceState, SliceName, CaseReducers>(
     initialState,
-    sliceActionNameGetter,
     actions,
     reducers,
     extraReducers
@@ -88,6 +87,7 @@ export function createNamespacedSlice<
   initialState,
   reducers,
   extraReducers,
+  reducersToActions,
   sliceActionNameGetter = defaultSliceActionNameGetter,
 }: SliceOptions<SliceName, SliceState, CaseReducers>): NamespacedSlice<
   SliceState,
@@ -104,6 +104,7 @@ export function createNamespacedSlice<
     initialState,
     reducers,
     extraReducers,
+    reducersToActions,
     sliceActionNameGetter,
   });