Return new documents on add, handle offline add #55
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the awesome library @nandorojo!
Related github issue
: #56
Changes
useCollection
add
calluseCollection
add
if offlineI noticed the
add
function provided byuseCollection
hasPromise<void>
as its return type. This could be improved by returning the added documents (including their new IDs) so thatadd
can be usedI realize this could be an anti-pattern since we're unaware as to what actually happens on the server if we use a batch add. This could be improved by only returning the doc ids.