ENSRainbow: Add purge command #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djstrong
changed the base branch from
main
to
252-ensrainbow-add-a-flag-to-the-validate-command-to-specify-if-it-should-be-a-full-validation-or-a-lite-validation
tk-o
reviewed
Feb 20, 2025
Co-authored-by: Tomek Kopacki <[email protected]>
lightwalker-eth
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
@djstrong Hey nice progress here 👍 You're welcome to merge this PR whenever you recommend. Any feedback I shared can be updated in this PR or a separate new PR. Up to you! Cheers!
| @@ -112,6 +117,22 @@ export function createCLI(options: CLIOptions = {}) { | |||
| }); | |||
| }, | |||
| ) | |||
| .command( | |||
There was a problem hiding this comment.
A few suggestions:
- Can you please add docs for this new command in the readme?
- Can you please review and refine error messages we might generate if a validation check fails? Ex: Ingestion unfinished, etc? For each of those error messages, suggest:
3. Including a suggestion to run this purge command.
4. Include a STRONG WARNING that running this purge command will completely remove all files in the specified directory.
Co-authored-by: lightwalker.eth <[email protected]>
djstrong
merged commit 1a4c1ab
into
252-ensrainbow-add-a-flag-to-the-validate-command-to-specify-if-it-should-be-a-full-validation-or-a-lite-validation
2 of 4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#253