-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Percussion keyboard shortcuts #26222
Draft
mathesoncalum
wants to merge
6
commits into
musescore:master
Choose a base branch
from
mathesoncalum:percussion_keyboard_shortcuts
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Percussion keyboard shortcuts #26222
mathesoncalum
wants to merge
6
commits into
musescore:master
from
mathesoncalum:percussion_keyboard_shortcuts
+850
−476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathesoncalum
force-pushed
the
percussion_keyboard_shortcuts
branch
3 times, most recently
from
January 24, 2025 16:10
be3f41a
to
dcb3ee8
Compare
mathesoncalum
force-pushed
the
percussion_keyboard_shortcuts
branch
from
January 24, 2025 16:16
dcb3ee8
to
6e4ba68
Compare
mathesoncalum
force-pushed
the
percussion_keyboard_shortcuts
branch
3 times, most recently
from
January 27, 2025 12:34
38853cc
to
e88e5ef
Compare
mathesoncalum
requested review from
Eism
and removed request for
cbjeukendrup
January 27, 2025 13:02
mathesoncalum
force-pushed
the
percussion_keyboard_shortcuts
branch
from
January 27, 2025 15:50
e88e5ef
to
4fa176c
Compare
Eism
reviewed
Jan 30, 2025
readonly property int buttonMinWidth: 104 | ||
} | ||
|
||
EditShortcutDialog { | ||
StyledDialogView { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's move it to separate file
Eism
reviewed
Jan 30, 2025
* MuseScore | ||
* Music Composition & Notation | ||
* | ||
* Copyright (C) 2024 MuseScore BVBA and others |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2025 :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements our new-and-improved percussion shortcuts. After these changes, it will be possble to use keys beyond
ABCDEFG
to input percussion notes.PR Overview
As outlined in the spec for this task, choosing “Define keyboard shortcut” from the percussion panel or editing shortcuts from the Customize kit dialog should prompt the user for an updated shortcut.
While the current flow provided by
EditShortcutModel
is quite similar to that of the new spec, it's clear that a more specialised model is required for percussion shortcuts (adding extra percussion-specific logic toEditShortcutModel
probably wouldn't be appropriate/coherent, especially considering it's part of the framework module). The logic we're interested in also requires some decoupling from preferences.To address this, 7984f8b extracts the content of our current
EditShortcutDialog
into anEditShortcutDialogContent
component which can be re-used with other models across the application. The second commit here (7219ade) implements theEditPercussionShortcutDialog
with an associatedEditPercussionShortcutModel
and provides a logic for opening it inPercussionUtilities
.Commit 6e4ba68 replaces the current shortcut dropdown in the customize kit dialog with a button that triggers the new flow, while commits cff5256 and 4fa176c lay the groundwork for actually using the expanded range of shortcuts for note input.
Next Steps
This isn't merge-ready yet. While this PR currently provides the logic/UI to assign expanded percussion shortcuts, they aren't usable without some tweaking to our note input logic. This will inevitably overlap with some other 4.5 tasks that are currently in-progress - the plan at the moment is to merge the other tasks before attempting the necessary tweaks here.