-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added RehearsalMark to midi export as Markers #26196
base: master
Are you sure you want to change the base?
Conversation
|
||
int tick = r->segment()->tick().ticks() + tickOffset; | ||
track.insert(CompatMidiRender::tick(context, tick), ev); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
trailing whitespace
Regarding the Codestyle check: In installed uncrustify on my windows machine and ran it in git bash. However other than complaining about an outdated configuration it did not throw any erros for the mentioned file.
EDIT: had to install 0.73 of uncrustify via |
The problem is that you need specifically version 0.73 of Uncrustify. (We decided to pin the version at some point, because every Uncrustify update required changes to the code, which was quite inconvenient in combination with the fact that updates are rolled out gradually over GitHub Actions runners, so you never know in advance whether you're going to get a the new or old version.) |
…icates, because they are the same fore each staff)
…icates, because they are the same fore each staff)
Don't use merge commits, but rebase (and force push): |
…icates, because they are the same fore each staff)
f03f165
to
1711ad8
Compare
Sorry, my vscode git integration keeps doing those in the background. I believe I have removed most of the unnecessary merge commits |
Resolves: Add Marker meta events to MIDI export and Exporting Rehearsal Markers to MIDI files
I want to export Rehearsal Marks to Midi Markers.
I export my sheetmusic as midi into a DAW, where Midi meta events such as Markers are supported.
Usually the sheetmusic contains Rehearsal Marks and I want the same structure to appear in my DAW.
This PR only adds export functionality. Import of Midi Markers to Rehearsal Marks is still missing.
I did not unit test the implementation but it works for the few examples I have on my machine.
I was also able to check it with python: