Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use General MIDI Percussion as the standard drumset #26176

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shoogle
Copy link
Contributor

@shoogle shoogle commented Jan 20, 2025

Requested by @zacjansheski.

As a result of this change, unrecognized percussion instruments in:

  • MIDI files are now imported with the General MIDI (GM) Percussion instrument instead of the Large Drum Kit, so have more drum pads available. This means that more percussion notes will be recognized.

  • Pre-3.6 MuseScore files are imported as Large Drum Kit if the instrument name includes "drum kit" or "drum set" (with or without spaces), otherwise as GM Percussion. No new pads are available in these files. That's because the pads are taken from the imported file rather than from instruments.xml. Presumably these files already contain all the pads they need.

  • MusicXML was previously imported as Mixed/Orchestral Percussion, possibly due to a bug in combinedTemplateSearch(), and that is unchanged by this PR.

@shoogle shoogle force-pushed the recognize-percussion-id branch from 45e7179 to a1f35c2 Compare January 20, 2025 22:59
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 21, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 21, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 21, 2025
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jan 21, 2025
@shoogle shoogle force-pushed the recognize-percussion-id branch 3 times, most recently from 2a352a4 to 62bf4fb Compare January 23, 2025 15:21
@shoogle shoogle changed the title Use correct MusicXML ID for unknown percussion instruments Use General MIDI Percussion as the standard drumset Jan 23, 2025
@shoogle shoogle force-pushed the recognize-percussion-id branch 2 times, most recently from f688f2f to 202d246 Compare January 24, 2025 06:26
The standard drumset is used for unknown percussion instruments found
when opening a pre-3.6 score or importing a non-native format like
MIDI, MusicXML, Guitar Pro, etc.

Also run the Python script to fetch the latest instrument data, which
now includes custom noteheads for some percussion instruments.
@shoogle shoogle force-pushed the recognize-percussion-id branch from 202d246 to f9ce346 Compare January 24, 2025 14:20
@shoogle shoogle marked this pull request as ready for review January 24, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant