Use General MIDI Percussion as the standard drumset #26176
+2,900
−1,095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requested by @zacjansheski.
As a result of this change, unrecognized percussion instruments in:
MIDI files are now imported with the General MIDI (GM) Percussion instrument instead of the Large Drum Kit, so have more drum pads available. This means that more percussion notes will be recognized.
Pre-3.6 MuseScore files are imported as Large Drum Kit if the instrument name includes "drum kit" or "drum set" (with or without spaces), otherwise as GM Percussion. No new pads are available in these files. That's because the pads are taken from the imported file rather than from
instruments.xml
. Presumably these files already contain all the pads they need.MusicXML was previously imported as Mixed/Orchestral Percussion, possibly due to a bug in combinedTemplateSearch(), and that is unchanged by this PR.