Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary textures cleanup #3978

Merged
merged 9 commits into from
Jan 28, 2025
Merged

Temporary textures cleanup #3978

merged 9 commits into from
Jan 28, 2025

Conversation

tederis
Copy link
Member

@tederis tederis commented Jan 25, 2025

Resolves #3977

Fernando-A-Rocha
Fernando-A-Rocha approved these changes Jan 25, 2025
View reviewed changes
Copy link
Contributor

@Fernando-A-Rocha Fernando-A-Rocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice system of automatic memory cleaning.

botder
botder previously approved these changes Jan 26, 2025
View reviewed changes
Copy link
Member

@botder botder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. What do you think about adding a timer to run CClientRenderElementManager::DoPulse() only every N (milli-)seconds?

@tederis
Copy link
Member Author

tederis commented Jan 28, 2025

LGTM. What do you think about adding a timer to run CClientRenderElementManager::DoPulse() only every N (milli-)seconds?

Yes, it makes sence.

@Dutchman101
Copy link
Member

This is huge, thanks

@Dutchman101 Dutchman101 merged commit f91e1de into multitheftauto:master Jan 28, 2025
3 of 6 checks passed
@botder botder added this to the 1.6.1 milestone Jan 28, 2025
@botder botder added the enhancement New feature or request label Jan 28, 2025
@tederis tederis deleted the temp_textures_cleanup branch January 29, 2025 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fernando-A-Rocha Fernando-A-Rocha Fernando-A-Rocha approved these changes

@TheNormalnij TheNormalnij TheNormalnij approved these changes

@botder botder botder left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.6.1
Development

Successfully merging this pull request may close these issues.

Memory leak, temporary textures not deleting
5 participants
@tederis @Dutchman101 @TheNormalnij @Fernando-A-Rocha @botder