Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds replacement CJ clothing models #3967
base: master
Are you sure you want to change the base?
Adds replacement CJ clothing models #3967
Changes from 4 commits
93606b5
0b8106c
363363d
38a520d
3b6b736
5c5619f
08606b2
0f1ceeb
18a2f7b
fa14863
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm pretty sure these structs already exist somewhere in the code, you should re-use that, instead of defining this here (even if not, you should move it out of this file, it doesn't belong here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't exist, I looked it up before I did it. But then I'll follow what TheNormalnij said, I'll create a CDirectorySA class and leave this structure there. I just haven't done it yet because I'm busy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed. DirectoryInfo repeats tImgFileInfo. You need to move DirectoryInfo to sdk and replace tImgFileInfo