Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip nick and serial checks if the server is a debug build #3909

Closed
wants to merge 2 commits into from

Conversation

Nico8340
Copy link
Contributor

Closes #3908

@tederis
Copy link
Member

tederis commented Dec 27, 2024

I don't think this is really needed. You can disable the check in mtaserver.conf. See check_duplicate_serials.

@Nico8340
Copy link
Contributor Author

Nico8340 commented Dec 27, 2024

I don't think this is really needed. You can disable the check in mtaserver.conf. See check_duplicate_serials.

I know, I was the one who implemented it and this idea was brought up by @FileEX, but regardless I don't think it's unnecessary, it's easier than having to manually turn it off in the config

@Nico8340
Copy link
Contributor Author

But you're right that it's not the most important change, it can be omitted

@FileEX
Copy link
Contributor

FileEX commented Dec 27, 2024

I don't think this is really needed. You can disable the check in mtaserver.conf. See check_duplicate_serials.

Can I also disable nick checks?

@tederis
Copy link
Member

tederis commented Dec 27, 2024

I don't think this is really needed. You can disable the check in mtaserver.conf. See check_duplicate_serials.

Can I also disable nick checks?

I don't think so. From what I can see this PR doesn't turn off nick checks as well.

@Nico8340 Nico8340 closed this Dec 27, 2024
@Nico8340 Nico8340 deleted the skipchecks branch December 27, 2024 16:38
@Nico8340
Copy link
Contributor Author

It was a mistake, it was supposed to disable nick checks as well. But it isn't really needed, we better solve the bug itself.

@FileEX
Copy link
Contributor

FileEX commented Dec 28, 2024

Since no one will fix this bug anytime soon, this solution would be much better. I see nothing wrong with disabling nickname checks. If this approach is considered bad, then let's add a 'check_duplicated_nicks' parameter to the mtaserver.conf as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Skip serial and nick checks in DEBUG mode
3 participants