Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[core] Resolve pnpm peer dep warnings #369

Merged
merged 1 commit into from
Jan 20, 2025
Merged

[core] Resolve pnpm peer dep warnings #369

merged 1 commit into from
Jan 20, 2025

Conversation

brijeshb42
Copy link
Contributor

@brijeshb42 brijeshb42 commented Jan 17, 2025 •
edited
Loading

Removes warnings when running pnpm i

 WARN  Issues with peer dependencies found
apps/local-ui-lib
├─┬ @emotion/react 11.13.3
│ ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
│ └─┬ @emotion/use-insertion-effect-with-fallbacks 1.1.0
│   └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
├─┬ @emotion/styled 11.13.0
│ └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
└─┬ @pigment-css/react 0.0.30
  ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
  └─┬ @mui/system 6.1.6
    ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
    ├─┬ @mui/utils 6.1.6
    │ └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
    ├─┬ @mui/private-theming 6.1.6
    │ └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
    └─┬ @mui/styled-engine 6.1.6
      └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021

docs
├─┬ @typescript-eslint/parser 7.6.0
│ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0
└─┬ eslint-config-next 15.0.2
  └─┬ @typescript-eslint/eslint-plugin 7.6.0
    ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0
    └─┬ @typescript-eslint/type-utils 7.6.0
      ├── ✕ unmet peer eslint@^8.56.0: found 9.17.0
      └─┬ @typescript-eslint/utils 7.6.0
        └── ✕ unmet peer eslint@^8.56.0: found 9.17.0

packages/eslint-plugin-material-ui
├─┬ @typescript-eslint/parser 7.6.0
│ └── ✕ unmet peer eslint@^8.56.0: found 9.17.0
└─┬ @typescript-eslint/experimental-utils 5.62.0
  ├── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0
  └─┬ @typescript-eslint/utils 5.62.0
    └── ✕ unmet peer eslint@"^6.0.0 || ^7.0.0 || ^8.0.0": found 9.17.0

packages/pigment-css-nextjs-plugin
├─┬ next 15.0.2
│ ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
│ ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
│ └─┬ styled-jsx 5.1.6
│   └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
└─┬ react-dom 19.0.0-rc-69d4b800-20241021
  └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021

packages/pigment-css-plugin
├─┬ next 15.1.4
│ ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
│ ├── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
│ └─┬ styled-jsx 5.1.6
│   └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021
└─┬ react-dom 19.0.0-rc-69d4b800-20241021
  └── ✕ unmet peer [email protected]: found 19.0.0-rc-69d4b800-20241021

@brijeshb42 brijeshb42 added the core Infrastructure work going on behind the scenes label Jan 17, 2025
mnajdova
mnajdova approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left just one comment

packages/pigment-css-react/package.json
Comment on lines +76 to +77
"react": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc",
"react-dom": "^17.0.0 || ^18.0.0 || ^19.0.0 || ^19.0.0-rc"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really need to add the rc packages as well?

@mnajdova mnajdova changed the title [core] resolve pnpm peer dep warnings [core] Resolve pnpm peer dep warnings Jan 20, 2025
@brijeshb42
Copy link
Contributor Author

I have not tested it but saw it added in base ui so added here as well.

@brijeshb42 brijeshb42 merged commit 46f2088 into mui:master Jan 20, 2025
13 checks passed
@brijeshb42 brijeshb42 deleted the fix/peer-deps branch January 20, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees
No one assigned
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brijeshb42 @mnajdova