Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[charts] Move item highligh feature to plugin system #16376

Closed
wants to merge 3 commits into from
Closed

[charts] Move item highligh feature to plugin system #16376

wants to merge 3 commits into from

Conversation

alexfauquette
Copy link
Member

The #16211 but rebase on master

@alexfauquette alexfauquette added the component: charts This is the name of the generic UI component, not the React module! label Jan 28, 2025
@mui-bot
Copy link

mui-bot commented Jan 28, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16376--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 7e440e3

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jan 28, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #16376 will degrade performances by 73.49%

Comparing alexfauquette:other-branche (7e440e3) with master (cbe47de)

Summary

⚡ 5 improvements
❌ 1 regressions

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⚡ BarChart with big data amount 923.9 ms 546.1 ms +69.18%
❌ BarChartPro with big data amount 218 ms 822.6 ms -73.49%
⚡ LineChart with big data amount 975.6 ms 318.3 ms ×3.1
⚡ LineChartPro with big data amount 528.6 ms 137.8 ms ×3.8
⚡ ScatterChart with big data amount 479.2 ms 393.5 ms +21.79%
⚡ ScatterChartPro with big data amount 125.7 ms 52.8 ms ×2.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: charts This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexfauquette @mui-bot