Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts] Add new bumpX and bumpY curve options #16318

Merged
merged 6 commits into from
Jan 27, 2025

Conversation

JCQuintas
Copy link
Member

  • Add new bumpX and bumpY curve options as they are better to use with funnel
  • Some small fixes I was too lazy to add to another PR 😁

@JCQuintas JCQuintas added enhancement This is not a bug, nor a new feature component: charts This is the name of the generic UI component, not the React module! labels Jan 23, 2025
@JCQuintas JCQuintas self-assigned this Jan 23, 2025
@mui-bot
Copy link

mui-bot commented Jan 23, 2025

Deploy preview: https://deploy-preview-16318--material-ui-x.netlify.app/

Updated pages:

Generated by 🚫 dangerJS against 778d810

Copy link

codspeed-hq bot commented Jan 23, 2025

CodSpeed Performance Report

Merging #16318 will not alter performance

Comparing JCQuintas:new-curve-and-fixes (778d810) with master (435d09f)

Summary

✅ 6 untouched benchmarks

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok to add them. I just left one concern about the docs

For a first version of the funnel I don't see that as necessary. Some straight lines could do the job

Comment on lines 18 to 20
'bumpY',
'bumpX',
];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be in favor of not documenting those options. I can see the interest for drawing a funnel chart but not a line chart. So I would not bother reader with additional option they might never use

Comment on lines 13 to 15
"labelMarkType": {
"description": "Defines the mark type for the series.<br /><br />There is a default mark type for each series type.<br /><br />It allows custom values which will be passed to the mark component if it was customized."
"description": "Defines the mark type for the series.<br /><br />There is a default mark type for each series type."
},
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did something change about how you see them used in the future?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is just not implemented right now

@JCQuintas
Copy link
Member Author

I'm ok to add them. I just left one concern about the docs

For a first version of the funnel I don't see that as necessary. Some straight lines could do the job

Curves were already implemented for a long time, I'm just extracting parts of the Funnel PR to make it smaller :)

@JCQuintas JCQuintas merged commit cbe47de into mui:master Jan 27, 2025
19 checks passed
@JCQuintas JCQuintas deleted the new-curve-and-fixes branch January 27, 2025 12:56
A-s-h-o-k pushed a commit to A-s-h-o-k/mui-x that referenced this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: charts This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants