[pickers] Move more field props to the context #16278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
breaking change
component: pickers
flaviendelangle
force-pushed
the
field-context-ui
branch
4 times, most recently
from
bd4ffba to
765e2a8
Compare
flaviendelangle
force-pushed
the
field-context-ui
branch
from
765e2a8 to
7d6fbd3
Compare
3 tasks
flaviendelangle
commented
Jan 24, 2025
| ]} | ||
| className={clsx(className, slotProps?.layout?.className)} | ||
| ref={ref} | ||
| sx={mergeSx(providerProps.contextValue.rootSx, slotProps?.layout?.sx)} |
There was a problem hiding this comment.
I'm using the context instead of direct prop access so that every component has the same data flow.
But these weird providerProps.xxx accesses will go away once we have the new structure.
flaviendelangle
force-pushed
the
field-context-ui
branch
4 times, most recently
from
f3b236b to
40c8435
Compare
flaviendelangle
force-pushed
the
field-context-ui
branch
from
40c8435 to
9b9ea88
Compare
JCQuintas
reviewed
Jan 27, 2025
| @@ -486,12 +513,14 @@ If the updated values do not fit your use case, you can [override them](/x/react | |||
| formatDensity='spacious' | |||
| selectedSections={selectedSections} | |||
| onSelectedSectionsChange={onSelectedSectionsChange} | |||
| inputRef={inputRef} | |||
There was a problem hiding this comment.
Did I get this wrong, or should this have a - in front of it to show the diff change?
There was a problem hiding this comment.
It should not
This section says that if you really want to still access those props on the field, then you can duplicate what you pass to the picker and also pass it to the field with slotProps.field.
It's clearly not something a lot of people should do
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
removed
the
PR: out-of-date
JCQuintas
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves all the props that comes directly from the
propsof the pickers and are passed as is to thepropsof the fields.It will help with #16175 because most of those props are not available on multi input range fields.
In this PR
Here are the props impacted:
classNamesxinputRefnamelabelrefownerState(not documented)Follow up
Here are the props we are still drilling:
focused(handled in [pickers] Move the opening logic to the range fields #16175)readOnly(handled in [pickers] Move the opening logic to the range fields #16175)