Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Update monorepo #16112

Merged
merged 22 commits into from
Feb 4, 2025
Merged

[code-infra] Update monorepo #16112

merged 22 commits into from
Feb 4, 2025
+45 −48

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Jan 9, 2025 •
edited
Loading

Fixes issues with #16422

Todo before merging:

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Jan 9, 2025
@Janpot Janpot changed the title [code-infra] Update monorepor [code-infra] Update monorepo Jan 9, 2025
@mui-bot
Copy link

mui-bot commented Jan 9, 2025 •
edited
Loading

Deploy preview: https://deploy-preview-16112--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 2df3a69

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 12, 2025
@github-actions GitHub Actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

This was referenced Jan 17, 2025
Merged
Draft
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 20, 2025
@LukasTy LukasTy mentioned this pull request Jan 27, 2025
Closed
1 task
@Janpot Janpot mentioned this pull request Feb 4, 2025
Open
1 task
@Janpot
Copy link
Member Author

Janpot commented Feb 4, 2025

@mui/xgrid Is that a flaky screenshot? It looks like the version on master is broken.

@Janpot Janpot marked this pull request as ready for review February 4, 2025 13:07
@Janpot Janpot requested a review from a team February 4, 2025 13:07
@cherniavskii
Copy link
Member

@mui/xgrid Is that a flaky screenshot? It looks like the version on master is broken.

I don't recall any issues with this one in particular, but it was added just recently.
Anyway, I've approved it since the screenshot generated in this PR is correct 👍🏻

cherniavskii
cherniavskii approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Janpot Janpot merged commit 0735942 into mui:master Feb 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cherniavskii cherniavskii cherniavskii approved these changes

@LukasTy LukasTy LukasTy approved these changes

Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Janpot @mui-bot @cherniavskii @LukasTy