Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[infra] Fix automated reviewers assignment workflow - part 2 #12989

Merged
merged 4 commits into from
May 4, 2024
Merged

[infra] Fix automated reviewers assignment workflow - part 2 #12989

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
18b93e9
fixes the usage of env vars and simplified URL
michelengelen May 3, 2024
6df02bf
Merge branch 'master' into automation/reviewers-assignment-fix-2
michelengelen May 3, 2024
8ab2825
review remarks
michelengelen May 4, 2024
da68f85
Merge remote-tracking branch 'origin/automation/reviewers-assignment-…
michelengelen May 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions .github/workflows/add-release-reviewers.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,11 @@ jobs:
# Tests that label is added on the PR
if: ${{ github.event.label.name == 'release' }}
runs-on: ubuntu-latest
env:
ORG: ${{ github.event.organization }}
# we can use the team slug when making this a reusable workflow
TEAM_SLUG: x
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
permissions:
contents: read
pull-requests: write
Expand All @@ -21,27 +26,18 @@ jobs:
DATA=$(gh api \
-H "Accept: application/vnd.github+json" \
-H "X-GitHub-Api-Version: 2022-11-28" \
/orgs/${{ORG}}/teams/${{TEAM_SLUG}}/members \
/orgs/$ORG/teams/$TEAM_SLUG/members?role=maintainer&per_page=100 \
| jq 'reduce inputs as $i (.; . += $i)') \
| echo "data=$DATA" >> $GITHUB_OUTPUT \
| echo "members=${{ join(fromJson(DATA).*.login) }}" >> $GITHUB_OUTPUT \
env:
ORG: ${{ github.event.organization }}
TEAM_SLUG: x
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
echo "data=$DATA" >> $GITHUB_OUTPUT
echo "members=${{ join(fromJson($DATA).*.login) }}" >> $GITHUB_OUTPUT

# assign reviewers
- id: assign-reviewers
run: |
curl -L \
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer ${{GITHUB_TOKEN}}" \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/${{ORG}}/${{REPO}}/pulls/${{PR_NUMBER}}/requested_reviewers \
-d '{"reviewers":[${{ steps.get-members.outputs.members }}]}' \
env:
ORG: ${{ github.event.organization }}
REPO: ${{ github.repository }}
PR_NUMBER: ${{ github.event.pull_request.number }}
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-X POST \
-H "Accept: application/vnd.github+json" \
-H "Authorization: Bearer $GITHUB_TOKEN" \
-H "X-GitHub-Api-Version: 2022-11-28" \
https://api.github.com/repos/$ORG/${{ github.repository }}/pulls/${{ github.event.pull_request.number }}/requested_reviewers \
-d '{"reviewers":[${{ steps.get-members.outputs.members }}]}' \