Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Disable flaky demos for visual regression test #44961

Closed
wants to merge 2 commits into from

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 7, 2025

There are 2 flaky regressions recently based on https://app.argos-ci.com/mui/material-ui:

  1. Disable Dashboard MainGrid
image
  1. Disable Pigment CSS x Material UI Progress by masking the flaky demo using data-playwright-masked attribute on the element.
image

@siriwatknp siriwatknp added the scope: docs-infra Specific to the docs-infra product label Jan 7, 2025
@siriwatknp siriwatknp requested review from mnajdova and a team January 7, 2025 09:36
@mui-bot
Copy link

mui-bot commented Jan 7, 2025

Netlify deploy preview

https://deploy-preview-44961--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against fb4d3f1

@@ -3,23 +3,12 @@ import reactPlugin from '@vitejs/plugin-react';
import Pages from 'vite-plugin-pages';
import { nodePolyfills } from 'vite-plugin-node-polyfills';
import { pigment } from '@pigment-css/vite-plugin';
import { extendTheme } from '@mui/material/styles';
import { createTheme } from '@mui/material/styles';
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extendTheme is deprecated.

@DiegoAndai
Copy link
Member

This flakiness might be related to #44920.

@Janpot and I are investigating. See also: #44969

@siriwatknp
Copy link
Member Author

Member

Okay, I'll put this on hold.

@DiegoAndai
Copy link
Member

DiegoAndai commented Jan 8, 2025

#44935 was merged; I think we'll need to fix the LinearProgress test anyway; the solution in #44969 is better than disabling IMO.

About the dashboard, let's wait to see if it goes away after #44935.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jan 8, 2025
@siriwatknp siriwatknp closed this Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold There is a blocker, we need to wait PR: out-of-date The pull request has merge conflicts and can't be merged scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants