Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Slider] Set CSS writing-mode and update vertical slider docs #44537

Merged
merged 22 commits into from
Dec 10, 2024
+394 −190
Merged

[material-ui][Slider] Set CSS writing-mode and update vertical slider docs #44537

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
3f04e20
Slider sets CSS writing-mode
mj12albert Nov 25, 2024
419c8d9
Fix CI
mj12albert Nov 25, 2024
7b6646e
Fix PR comments
mj12albert Nov 25, 2024
9dc7bf7
Fix grammar
mj12albert Nov 25, 2024
5a25a2d
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Nov 25, 2024
e317872
Add a test
mj12albert Nov 25, 2024
fdc1487
Fix keydown handling
mj12albert Nov 25, 2024
57af0e8
Handle all keypresses
mj12albert Nov 26, 2024
699ace5
Merge remote-tracking branch 'upstream/master' into fix/vertical-slid…
mj12albert Nov 26, 2024
e0ac8e1
Merge remote-tracking branch 'upstream/master' into fix/vertical-slid…
mj12albert Nov 27, 2024
93083a8
Consolidate keyboard interaction tests
mj12albert Nov 27, 2024
cc32deb
Use strings for keys
mj12albert Nov 27, 2024
415c1ad
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Nov 28, 2024
7f5ff37
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Nov 29, 2024
1979ca9
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Nov 29, 2024
e1db01a
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Nov 30, 2024
f3261d6
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Dec 2, 2024
e5371ea
Merge remote-tracking branch 'upstream/master' into fix/vertical-slid…
mj12albert Dec 3, 2024
f463c0f
Fixes
mj12albert Dec 3, 2024
9f9587c
Fix grammar
mj12albert Dec 3, 2024
c279aea
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Dec 3, 2024
7981bcc
Merge branch 'master' into fix/vertical-slider-a11y
mj12albert Dec 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix grammar
@mj12albert
mj12albert committed Dec 3, 2024
commit 9f9587cc99a273d50148467544460c5751e0c8cb
2 changes: 1 addition & 1 deletion docs/data/material/components/slider/slider.md
View file
Original file line number Diff line number Diff line change
@@ -98,12 +98,12 @@

## Vertical sliders

Set the `orientation` prop to `"vertical"` to create vertical sliders. The thumb will track vertical movement instead of horizontal movement.

Check warning on line 101 in docs/data/material/components/slider/slider.md

GitHub Actions / runner / vale 

[vale] reported by reviewdog 🐶
[Google.Will] Avoid using 'will'.

Raw Output:
{"message": "[Google.Will] Avoid using 'will'.", "location": {"path": "docs/data/material/components/slider/slider.md", "range": {"start": {"line": 101, "column": 82}}}, "severity": "WARNING"}

{{"demo": "VerticalSlider.js"}}

:::warning
Chrome versions below 124 implement `aria-orientation` incorrectly for vertical sliders and exposes them as `'horizontal'` in the accessibility tree. ([Chromium issue #40736841](https://issues.chromium.org/issues/40736841))
Chrome versions below 124 implement `aria-orientation` incorrectly for vertical sliders and expose them as `'horizontal'` in the accessibility tree. ([Chromium issue #40736841](https://issues.chromium.org/issues/40736841))

The `-webkit-appearance: slider-vertical` CSS property can be used to correct this for these older versions, with the trade-off of causing a console warning in newer Chrome versions: