Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test] Speed up regression and E2E tests #1354

Merged
merged 2 commits into from
Jan 24, 2025
Merged

[test] Speed up regression and E2E tests #1354

merged 2 commits into from
Jan 24, 2025

Conversation

michaldudak
Copy link
Member

@michaldudak michaldudak commented Jan 23, 2025 •
edited
Loading

Ported mui/material-ui#44935: removed React.Suspense from around tests and mocked clock.

@michaldudak michaldudak requested a review from a team January 23, 2025 13:51
@michaldudak michaldudak requested a review from atomiks as a code owner January 23, 2025 13:51
@netlify Netlify
Copy link

netlify bot commented Jan 23, 2025 •
edited
Loading

✅ Deploy Preview for base-ui ready!

Name Link
🔨 Latest commit 326b1c6
🔍 Latest deploy log https://app.netlify.com/sites/base-ui/deploys/67938c699362a5000922802c
😎 Deploy Preview https://deploy-preview-1354--base-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mj12albert
mj12albert approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, the regression test went from 1m13s in the previous PR to 25s here 🔥

Janpot
Janpot approved these changes Jan 23, 2025
View reviewed changes
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet. Planning to try removing the lazy components as well? Curious if it'll make a difference.

@michaldudak
Copy link
Member Author

It did not. The latest run was 28s, so comparable to the one with lazy import resolution. I'd keep the changed one for simplicity, though.

@michaldudak michaldudak merged commit 2d94ab9 into mui:master Jan 24, 2025
23 checks passed
@michaldudak michaldudak deleted the speed-up-tests branch January 24, 2025 14:18
@Janpot
Copy link
Member

Janpot commented Jan 24, 2025

👍 Ok, to keep in mind this may potentially slow down initial startup of dev mode as it scales.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mj12albert mj12albert mj12albert approved these changes

@Janpot Janpot Janpot approved these changes

@atomiks atomiks Awaiting requested review from atomiks atomiks is a code owner

Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michaldudak @Janpot @mj12albert