Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfixs: Do not prefix kind keys in addConsumerKind and addProducerKind. #27

Merged
merged 1 commit into from
Feb 11, 2024
Merged

Bugfixs: Do not prefix kind keys in addConsumerKind and addProducerKind. #27

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Monitor/Tracing/Zipkin.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ addTag key val bldr =
-- Use this method if you want to create a root consumer span. Otherwise use 'consumerSpanWith' to
-- create a sub span with consumer kind.
addConsumerKind :: Builder -> Builder
addConsumerKind = addTag kindKey consumerKindValue
addConsumerKind = appEndo $ insertTag kindKey consumerKindValue

-- | Adds a producer kind tag to a builder. This is a convenience method to use with 'rootSpanWith',
-- for example:
Expand All @@ -193,7 +193,7 @@ addConsumerKind = addTag kindKey consumerKindValue
-- Use this method if you want to create a root producer span. Otherwise use 'producerSpanWith' to
-- create a sub span with producer kind.
addProducerKind :: Builder -> Builder
addProducerKind = addTag kindKey producerKindValue
addProducerKind = appEndo $ insertTag kindKey producerKindValue

-- | Adds an inherited tag to a builder. Unlike a tag added via 'addTag', this tag:
--
Expand Down