[1.254.*] Pre-release merge #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![tramline-github[bot]](https://avatars.githubusercontent.com/in/166919?s=60&v=4){kind=small}
…he feed icon (#820) * Fetch feed icon when parsing the feeds part of #785 * Add preference to show feed fav icon * Add `showFeedFavIcon` column to `Feed` table This along with the global setting will be used to determine if we use the fav icon or the feed icon * Rename `FeedFavIcon` composable to `FeedIcon` * Load `showFeedFavIcon` setting in the `AppPresenter` * Provide `showFeedFavIcon` setting as a composition local While it's not recommended to pass a dependency like this, this setting is akin to a theme setting imo where we switch between the source of the feed icon. So doing this approach for simplicity and having to load the setting and make changes at screen level * Add feed icon links to `FeedGroup` * Switch between feed fav icon and feed icon based on show feed fav icon setting * Load show feed fav icon setting in `SettingsPresenter` * Display show feed fav icon setting in `SettingsScreen`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new release train Nightly is starting. The main branch has to be merged into nightly branch.