Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ci: pin nightly (#2370)" #2371

Merged
merged 1 commit into from
Jan 17, 2025
Merged

Revert "ci: pin nightly (#2370)" #2371

merged 1 commit into from
Jan 17, 2025

Conversation

mxinden
Copy link
Collaborator

@mxinden mxinden commented Jan 17, 2025

This reverts commit e18658d.

@codecov Codecov
Copy link

codecov bot commented Jan 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.29%. Comparing base (e18658d) to head (dafb9f4).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2371   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files         114      114           
  Lines       36856    36856           
  Branches    36856    36856           
=======================================
  Hits        35123    35123           
  Misses       1727     1727           
  Partials        6        6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 17, 2025 •
edited
Loading

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to e18658d.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@mxinden mxinden marked this pull request as ready for review January 17, 2025 10:52
@mxinden
Copy link
Collaborator Author

mxinden commented Jan 17, 2025 •
edited
Loading

Windows Nightly failure (i.e. #2369) is gone. Thus we can revert back to latest Nightly again.

Once this is merged, we can continue with #2364.

@mxinden mxinden added this pull request to the merge queue Jan 17, 2025
Merged via the queue into mozilla:main with commit a7b33a3 Jan 17, 2025
95 of 105 checks passed
@mxinden mxinden deleted the revert-pin-nightly branch January 17, 2025 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larseggert larseggert larseggert approved these changes

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mxinden @larseggert