Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Unpin nightly #2338

Merged
merged 1 commit into from
Jan 10, 2025
Merged

ci: Unpin nightly #2338

merged 1 commit into from
Jan 10, 2025

Conversation

larseggert
Copy link
Collaborator

Copy link

codecov bot commented Jan 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.33%. Comparing base (763ac2c) to head (0697311).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2338   +/-   ##
=======================================
  Coverage   93.33%   93.33%           
=======================================
  Files         114      114           
  Lines       36887    36887           
  Branches    36887    36887           
=======================================
  Hits        34428    34428           
  Misses       1679     1679           
  Partials      780      780           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to 6013bde.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

@larseggert larseggert enabled auto-merge January 10, 2025 06:36
Copy link

Benchmark results

Performance differences relative to 6013bde.

decode 4096 bytes, mask ff: No change in performance detected.
       time:   [11.167 µs 11.204 µs 11.248 µs]
       change: [-0.0355% +0.4654% +1.0706%] (p = 0.09 > 0.05)

Found 15 outliers among 100 measurements (15.00%)
2 (2.00%) low mild
2 (2.00%) high mild
11 (11.00%) high severe

decode 1048576 bytes, mask ff: No change in performance detected.
       time:   [3.0185 ms 3.0381 ms 3.0680 ms]
       change: [-0.4514% +0.3144% +1.3471%] (p = 0.56 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) high mild
9 (9.00%) high severe

decode 4096 bytes, mask 7f: No change in performance detected.
       time:   [19.516 µs 19.562 µs 19.615 µs]
       change: [-1.0037% -0.3168% +0.1950%] (p = 0.35 > 0.05)

Found 18 outliers among 100 measurements (18.00%)
2 (2.00%) low severe
2 (2.00%) low mild
2 (2.00%) high mild
12 (12.00%) high severe

decode 1048576 bytes, mask 7f: No change in performance detected.
       time:   [5.1601 ms 5.1714 ms 5.1842 ms]
       change: [-0.4455% -0.0906% +0.2641%] (p = 0.61 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
16 (16.00%) high severe

decode 4096 bytes, mask 3f: No change in performance detected.
       time:   [5.5282 µs 5.5469 µs 5.5722 µs]
       change: [-0.9835% -0.2539% +0.3840%] (p = 0.51 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
5 (5.00%) low mild
2 (2.00%) high mild
3 (3.00%) high severe

decode 1048576 bytes, mask 3f: No change in performance detected.
       time:   [1.7611 ms 1.7667 ms 1.7736 ms]
       change: [-0.4595% +0.0822% +0.5623%] (p = 0.74 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
3 (3.00%) high mild
7 (7.00%) high severe

coalesce_acked_from_zero 1+1 entries: No change in performance detected.
       time:   [98.632 ns 98.965 ns 99.314 ns]
       change: [-0.4839% -0.0824% +0.2892%] (p = 0.68 > 0.05)

Found 10 outliers among 100 measurements (10.00%)
1 (1.00%) high mild
9 (9.00%) high severe

coalesce_acked_from_zero 3+1 entries: No change in performance detected.
       time:   [116.64 ns 117.02 ns 117.43 ns]
       change: [-0.8104% +0.0658% +0.7716%] (p = 0.88 > 0.05)

Found 16 outliers among 100 measurements (16.00%)
1 (1.00%) low severe
1 (1.00%) low mild
14 (14.00%) high severe

coalesce_acked_from_zero 10+1 entries: No change in performance detected.
       time:   [116.04 ns 116.31 ns 116.70 ns]
       change: [-0.6810% +0.0291% +0.8198%] (p = 0.94 > 0.05)

Found 9 outliers among 100 measurements (9.00%)
1 (1.00%) low severe
2 (2.00%) low mild
1 (1.00%) high mild
5 (5.00%) high severe

coalesce_acked_from_zero 1000+1 entries: No change in performance detected.
       time:   [98.075 ns 98.195 ns 98.337 ns]
       change: [-0.8064% +0.3872% +1.5165%] (p = 0.54 > 0.05)

Found 13 outliers among 100 measurements (13.00%)
7 (7.00%) high mild
6 (6.00%) high severe

RxStreamOrderer::inbound_frame(): No change in performance detected.
       time:   [110.87 ms 111.01 ms 111.24 ms]
       change: [-0.3314% -0.0778% +0.1485%] (p = 0.59 > 0.05)

Found 20 outliers among 100 measurements (20.00%)
9 (9.00%) low mild
9 (9.00%) high mild
2 (2.00%) high severe

SentPackets::take_ranges: No change in performance detected.
       time:   [5.4976 µs 5.6584 µs 5.8198 µs]
       change: [-2.8701% +5.1956% +18.857%] (p = 0.57 > 0.05)

Found 4 outliers among 100 measurements (4.00%)
3 (3.00%) high mild
1 (1.00%) high severe

transfer/pacing-false/varying-seeds: Change within noise threshold.
       time:   [41.143 ms 41.229 ms 41.322 ms]
       change: [-1.4901% -1.1808% -0.8732%] (p = 0.00 < 0.05)

Found 3 outliers among 100 measurements (3.00%)
2 (2.00%) high mild
1 (1.00%) high severe

transfer/pacing-true/varying-seeds: Change within noise threshold.
       time:   [41.614 ms 41.688 ms 41.766 ms]
       change: [-1.0220% -0.7875% -0.5296%] (p = 0.00 < 0.05)

Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe

transfer/pacing-false/same-seed: Change within noise threshold.
       time:   [40.977 ms 41.035 ms 41.094 ms]
       change: [-2.1002% -1.8714% -1.6416%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold.
       time:   [41.095 ms 41.165 ms 41.245 ms]
       change: [-2.4700% -2.2242% -1.9535%] (p = 0.00 < 0.05)

Found 2 outliers among 100 measurements (2.00%)
1 (1.00%) high mild
1 (1.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: Change within noise threshold.
       time:   [891.79 ms 901.18 ms 910.61 ms]
       thrpt:  [109.82 MiB/s 110.97 MiB/s 112.13 MiB/s]
change:
       time:   [+0.0902% +1.6106% +3.1829%] (p = 0.04 < 0.05)
       thrpt:  [-3.0847% -1.5851% -0.0901%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected.
       time:   [299.75 ms 302.04 ms 304.37 ms]
       thrpt:  [32.855 Kelem/s 33.109 Kelem/s 33.361 Kelem/s]
change:
       time:   [-1.1370% -0.1117% +0.9597%] (p = 0.84 > 0.05)
       thrpt:  [-0.9506% +0.1118% +1.1501%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: Change within noise threshold.
       time:   [33.812 ms 33.987 ms 34.173 ms]
       thrpt:  [29.263  elem/s 29.423  elem/s 29.575  elem/s]
change:
       time:   [-1.6925% -0.9294% -0.1613%] (p = 0.02 < 0.05)
       thrpt:  [+0.1615% +0.9382% +1.7217%]

Found 4 outliers among 100 measurements (4.00%)
1 (1.00%) low mild
1 (1.00%) high mild
2 (2.00%) high severe

1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected.
       time:   [1.6456 s 1.6647 s 1.6839 s]
       thrpt:  [59.385 MiB/s 60.070 MiB/s 60.768 MiB/s]
change:
       time:   [-1.3157% +0.3274% +1.9434%] (p = 0.69 > 0.05)
       thrpt:  [-1.9063% -0.3263% +1.3332%]

Client/server transfer results

Transfer of 33554432 bytes over loopback.

Client Server CC Pacing MTU Mean [ms] Min [ms] Max [ms]
gquiche gquiche 1504 540.2 ± 56.7 502.9 684.4
neqo gquiche reno on 1504 784.9 ± 76.3 744.6 975.5
neqo gquiche reno 1504 832.0 ± 114.8 757.9 1078.7
neqo gquiche cubic on 1504 824.3 ± 153.8 736.0 1222.1
neqo gquiche cubic 1504 787.5 ± 75.2 735.3 949.6
msquic msquic 1504 220.6 ± 104.4 100.9 381.0
neqo msquic reno on 1504 286.1 ± 101.6 211.2 524.0
neqo msquic reno 1504 282.6 ± 117.9 210.9 611.7
neqo msquic cubic on 1504 284.3 ± 93.3 214.8 432.4
neqo msquic cubic 1504 249.5 ± 78.7 204.8 459.1
gquiche neqo reno on 1504 709.5 ± 98.2 560.2 846.7
gquiche neqo reno 1504 748.4 ± 176.9 596.0 1201.4
gquiche neqo cubic on 1504 749.1 ± 140.7 581.0 1019.8
gquiche neqo cubic 1504 773.8 ± 223.0 561.9 1244.1
msquic neqo reno on 1504 490.6 ± 36.1 442.6 576.7
msquic neqo reno 1504 535.7 ± 85.4 477.0 738.1
msquic neqo cubic on 1504 534.4 ± 83.0 473.8 679.8
msquic neqo cubic 1504 506.8 ± 35.4 481.5 605.0
neqo neqo reno on 1504 485.1 ± 26.4 439.4 520.3
neqo neqo reno 1504 519.3 ± 56.1 463.0 607.0
neqo neqo cubic on 1504 560.1 ± 37.0 509.0 641.7
neqo neqo cubic 1504 560.1 ± 10.5 543.8 573.7

⬇️ Download logs

Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@larseggert larseggert added this pull request to the merge queue Jan 10, 2025
Merged via the queue into mozilla:main with commit c9f5a36 Jan 10, 2025
64 checks passed
@larseggert larseggert deleted the ci-unpin-nightly branch January 10, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants