Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Enable the shadow_same lint #2329

Closed
wants to merge 1 commit into from
Closed

chore: Enable the shadow_same lint #2329

wants to merge 1 commit into from

Conversation

larseggert
Copy link
Collaborator

And fix the lint errors in the codebase.

@larseggert
chore: Enable the shadow_same lint
8b060cb 
And fix the lint errors in the codebase.
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 9, 2025

Failed Interop Tests

QUIC Interop Runner, client vs. server, differences relative to ef9e4dc.

neqo-latest as client

neqo-latest as server

All results

Succeeded Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

Unsupported Interop Tests

QUIC Interop Runner, client vs. server

neqo-latest as client

neqo-latest as server

mxinden
mxinden reviewed Jan 9, 2025
View reviewed changes
Copy link
Collaborator

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I consider the following a helpful pattern:

let mut x = todo!();
// mutate x

// x won't be mutated from now on. Make it immutable.
let x = x;

Why explicitly disallow this?

@larseggert
Copy link
Collaborator Author

I have not used that pattern. If you find it useful, let's not merge this.

@larseggert larseggert closed this Jan 9, 2025
@mxinden
Copy link
Collaborator

mxinden commented Jan 9, 2025

We have been using it e.g. here https://github.com/mozilla/mtu/pull/4/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mxinden mxinden mxinden left review comments

@KershawChang KershawChang Awaiting requested review from KershawChang KershawChang is a code owner

@martinthomson martinthomson Awaiting requested review from martinthomson martinthomson is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larseggert @mxinden