chore: Enable the semicolon_inside_block lint
#2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what we mostly use in the code.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 6013bde. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Jan 9, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2328 +/- ##
==========================================
- Coverage 93.33% 93.32% -0.01%
==========================================
Files 114 114
Lines 36887 36889 +2
Branches 36887 36889 +2
==========================================
Hits 34428 34428
- Misses 1679 1681 +2
Partials 780 780 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.150 µs 11.177 µs 11.212 µs]
change: [-0.1724% +0.1893% +0.6062%] (p = 0.36 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0173 ms 3.0270 ms 3.0380 ms]
change: [-0.5567% -0.0516% +0.4428%] (p = 0.85 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.541 µs 19.597 µs 19.662 µs]
change: [-0.7326% -0.0143% +0.5824%] (p = 0.97 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1591 ms 5.1706 ms 5.1836 ms]
change: [-0.4547% -0.1077% +0.2492%] (p = 0.55 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5338 µs 5.5604 µs 5.5928 µs]
change: [-0.8423% -0.0383% +0.7033%] (p = 0.93 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7580 ms 1.7609 ms 1.7651 ms]
change: [-0.6424% -0.2471% +0.1449%] (p = 0.23 > 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.385 ns 99.793 ns 100.20 ns]
change: [+0.1658% +0.5972% +1.0036%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.49 ns 117.84 ns 118.21 ns]
change: [-0.1956% +0.6716% +1.3127%] (p = 0.07 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.12 ns 117.52 ns 118.04 ns]
change: [+0.2411% +0.9300% +1.6321%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.531 ns 98.681 ns 98.844 ns]
change: [-0.0125% +1.2885% +2.6713%] (p = 0.06 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [110.99 ms 111.05 ms 111.11 ms]
change: [-0.2454% -0.0440% +0.0907%] (p = 0.71 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4923 µs 5.6501 µs 5.8170 µs]
change: [-1.7439% +0.8527% +3.4863%] (p = 0.52 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [42.778 ms 42.875 ms 42.977 ms]
change: [+2.4456% +2.7640% +3.0927%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [43.083 ms 43.175 ms 43.275 ms]
change: [+2.4614% +2.7521% +3.0297%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [42.618 ms 42.687 ms 42.764 ms]
change: [+1.8182% +2.0775% +2.3224%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [43.048 ms 43.118 ms 43.191 ms]
change: [+2.1621% +2.4127% +2.6588%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [869.62 ms 879.02 ms 888.63 ms]
thrpt: [112.53 MiB/s 113.76 MiB/s 114.99 MiB/s]
change:
time: [-2.4225% -0.8880% +0.6161%] (p = 0.26 > 0.05)
thrpt: [-0.6123% +0.8960% +2.4826%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [300.63 ms 302.38 ms 304.10 ms]
thrpt: [32.884 Kelem/s 33.071 Kelem/s 33.264 Kelem/s]
change:
time: [-0.8944% +0.0014% +0.9542%] (p = 1.00 > 0.05)
thrpt: [-0.9452% -0.0014% +0.9024%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.255 ms 34.453 ms 34.673 ms]
thrpt: [28.841 elem/s 29.025 elem/s 29.193 elem/s]
change:
time: [-0.4334% +0.4313% +1.2776%] (p = 0.32 > 0.05)
thrpt: [-1.2614% -0.4295% +0.4353%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: No change in performance detected. time: [1.6275 s 1.6439 s 1.6602 s]
thrpt: [60.232 MiB/s 60.832 MiB/s 61.442 MiB/s]
change:
time: [-2.3866% -0.9280% +0.6094%] (p = 0.23 > 0.05)
thrpt: [-0.6057% +0.9367% +2.4449%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what we mostly use in the code.