chore: Enable the renamed_function_params lint
#2327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix all the warnings.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to ef9e4dc. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2327 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 114 114
Lines 36908 36908
Branches 36908 36908
=======================================
Hits 34451 34451
Misses 1675 1675
Partials 782 782 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to ef9e4dc. decode 4096 bytes, mask ff: No change in performance detected. time: [11.162 µs 11.200 µs 11.244 µs]
change: [-0.5161% -0.1593% +0.2244%] (p = 0.43 > 0.05)
decode 1048576 bytes, mask ff: 💔 Performance has regressed. time: [3.0138 ms 3.0216 ms 3.0310 ms]
change: [+3.8296% +4.3457% +4.8191%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.508 µs 19.557 µs 19.616 µs]
change: [-0.2569% +0.2338% +0.8305%] (p = 0.46 > 0.05)
decode 1048576 bytes, mask 7f: 💔 Performance has regressed. time: [5.1614 ms 5.1744 ms 5.1892 ms]
change: [+1.3196% +1.7215% +2.1257%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5270 µs 5.5522 µs 5.5829 µs]
change: [-0.9467% -0.3441% +0.2038%] (p = 0.27 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7621 ms 1.7688 ms 1.7771 ms]
change: [+23.847% +24.612% +25.390%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [98.723 ns 99.089 ns 99.483 ns]
change: [-0.4512% -0.0292% +0.3605%] (p = 0.89 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.85 ns 117.26 ns 117.69 ns]
change: [-0.1138% +0.3048% +0.7664%] (p = 0.18 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.06 ns 116.30 ns 116.63 ns]
change: [-0.8477% -0.0864% +0.6440%] (p = 0.84 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.532 ns 97.684 ns 97.860 ns]
change: [-0.0756% +0.8966% +1.8989%] (p = 0.08 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [111.27 ms 111.34 ms 111.40 ms]
change: [-0.1308% -0.0473% +0.0356%] (p = 0.27 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5511 µs 5.7647 µs 6.0011 µs]
change: [-14.434% -2.5489% +6.0616%] (p = 0.77 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [41.555 ms 41.631 ms 41.706 ms]
change: [-3.5518% -3.3092% -3.0664%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [41.633 ms 41.705 ms 41.777 ms]
change: [-3.8813% -3.6551% -3.4125%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.520 ms 41.579 ms 41.640 ms]
change: [-3.0696% -2.8724% -2.6831%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [41.685 ms 41.752 ms 41.817 ms]
change: [-4.1060% -3.9230% -3.7123%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [884.56 ms 893.39 ms 902.59 ms]
thrpt: [110.79 MiB/s 111.93 MiB/s 113.05 MiB/s]
change:
time: [-0.9450% +0.5908% +2.1223%] (p = 0.44 > 0.05)
thrpt: [-2.0782% -0.5873% +0.9540%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [298.98 ms 301.09 ms 303.22 ms]
thrpt: [32.979 Kelem/s 33.213 Kelem/s 33.447 Kelem/s]
change:
time: [-1.4948% -0.5077% +0.4646%] (p = 0.31 > 0.05)
thrpt: [-0.4624% +0.5103% +1.5175%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.756 ms 34.931 ms 35.126 ms]
thrpt: [28.469 elem/s 28.628 elem/s 28.772 elem/s]
change:
time: [-0.2882% +0.6166% +1.5277%] (p = 0.18 > 0.05)
thrpt: [-1.5047% -0.6128% +0.2890%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.6199 s 1.6355 s 1.6515 s]
thrpt: [60.550 MiB/s 61.142 MiB/s 61.734 MiB/s]
change:
time: [-4.7752% -3.4859% -2.2236%] (p = 0.00 < 0.05)
thrpt: [+2.2742% +3.6118% +5.0146%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix all the warnings.