chore: Enable clippy multiple_inherent_impl lint
#2323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix all the warnings.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2323 +/- ##
=======================================
Coverage 93.34% 93.34%
=======================================
Files 114 114
Lines 36908 36908
Branches 36908 36908
=======================================
Hits 34451 34451
Misses 1675 1675
Partials 782 782 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to ef9e4dc. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to ef9e4dc. decode 4096 bytes, mask ff: No change in performance detected. time: [11.178 µs 11.222 µs 11.272 µs]
change: [-0.3505% +0.1824% +0.6875%] (p = 0.55 > 0.05)
decode 1048576 bytes, mask ff: 💔 Performance has regressed. time: [3.0141 ms 3.0219 ms 3.0312 ms]
change: [+3.8403% +4.3557% +4.8073%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.508 µs 19.557 µs 19.614 µs]
change: [-0.5138% -0.2388% +0.0373%] (p = 0.10 > 0.05)
decode 1048576 bytes, mask 7f: 💔 Performance has regressed. time: [5.1615 ms 5.1741 ms 5.1874 ms]
change: [+1.3326% +1.7158% +2.1220%] (p = 0.00 < 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5438 µs 5.5743 µs 5.6107 µs]
change: [-0.5379% +0.4330% +1.4479%] (p = 0.42 > 0.05)
decode 1048576 bytes, mask 3f: 💔 Performance has regressed. time: [1.7664 ms 1.7747 ms 1.7843 ms]
change: [+24.223% +25.027% +25.836%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.072 ns 99.406 ns 99.748 ns]
change: [-0.0178% +0.4354% +0.9063%] (p = 0.05 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.88 ns 117.19 ns 117.53 ns]
change: [-0.1191% +0.1892% +0.4914%] (p = 0.24 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.53 ns 116.92 ns 117.41 ns]
change: [-0.3541% +0.4967% +1.3504%] (p = 0.28 > 0.05)
coalesce_acked_from_zero 1000+1 entries: Change within noise threshold. time: [98.136 ns 98.248 ns 98.370 ns]
change: [+0.2366% +1.2484% +2.3745%] (p = 0.01 < 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.09 ms 111.15 ms 111.21 ms]
change: [-0.2904% -0.2148% -0.1407%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5069 µs 5.6566 µs 5.8147 µs]
change: [-15.330% -3.6610% +4.6812%] (p = 0.68 > 0.05)
transfer/pacing-false/varying-seeds: 💚 Performance has improved. time: [41.135 ms 41.215 ms 41.294 ms]
change: [-4.5089% -4.2757% -4.0367%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💚 Performance has improved. time: [41.232 ms 41.309 ms 41.385 ms]
change: [-4.8199% -4.5710% -4.3253%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💚 Performance has improved. time: [40.765 ms 40.824 ms 40.884 ms]
change: [-4.8281% -4.6367% -4.4401%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💚 Performance has improved. time: [40.922 ms 40.977 ms 41.031 ms]
change: [-5.8894% -5.7077% -5.5232%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [883.39 ms 892.82 ms 902.45 ms]
thrpt: [110.81 MiB/s 112.01 MiB/s 113.20 MiB/s]
change:
time: [-1.0130% +0.5262% +2.1236%] (p = 0.50 > 0.05)
thrpt: [-2.0794% -0.5235% +1.0233%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [299.51 ms 301.63 ms 303.76 ms]
thrpt: [32.920 Kelem/s 33.153 Kelem/s 33.388 Kelem/s]
change:
time: [-1.2531% -0.3278% +0.6863%] (p = 0.51 > 0.05)
thrpt: [-0.6817% +0.3289% +1.2690%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.238 ms 34.421 ms 34.624 ms]
thrpt: [28.882 elem/s 29.052 elem/s 29.207 elem/s]
change:
time: [-1.7579% -0.8529% +0.0405%] (p = 0.07 > 0.05)
thrpt: [-0.0405% +0.8602% +1.7893%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6400 s 1.6563 s 1.6726 s]
thrpt: [59.787 MiB/s 60.376 MiB/s 60.974 MiB/s]
change:
time: [-3.6317% -2.2613% -0.9901%] (p = 0.00 < 0.05)
thrpt: [+1.0000% +2.3136% +3.7686%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <[email protected]>
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And fix all the warnings.