chore: Enable some rustc lints #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And deal with the fallout.
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2317 +/- ##
=======================================
Coverage 93.33% 93.33%
=======================================
Files 114 114
Lines 36887 36887
Branches 36887 36887
=======================================
Hits 34428 34428
Misses 1679 1679
Partials 780 780 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to 6013bde. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
mxinden
approved these changes
Jan 8, 2025
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.155 µs 11.234 µs 11.373 µs]
change: [-0.1133% +0.6401% +1.7565%] (p = 0.22 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0109 ms 3.0165 ms 3.0236 ms]
change: [-0.8241% -0.3998% +0.0075%] (p = 0.06 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.522 µs 19.586 µs 19.667 µs]
change: [-0.7822% -0.0699% +0.5426%] (p = 0.85 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1604 ms 5.1721 ms 5.1851 ms]
change: [-0.4216% -0.0773% +0.2769%] (p = 0.67 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5257 µs 5.5364 µs 5.5558 µs]
change: [-1.0427% -0.2890% +0.5039%] (p = 0.50 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7581 ms 1.7596 ms 1.7625 ms]
change: [-0.7118% -0.3204% +0.0056%] (p = 0.10 > 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.417 ns 99.784 ns 100.15 ns]
change: [+0.3466% +0.8613% +1.4423%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [117.44 ns 117.87 ns 118.37 ns]
change: [-0.3203% +0.5498% +1.2320%] (p = 0.18 > 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.23 ns 117.77 ns 118.39 ns]
change: [+0.1758% +0.8234% +1.4662%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.401 ns 98.550 ns 98.725 ns]
change: [-0.3519% +0.8588% +1.9821%] (p = 0.16 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.24 ms 111.31 ms 111.37 ms]
change: [-0.0201% +0.1860% +0.3190%] (p = 0.02 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.5374 µs 5.7339 µs 5.9480 µs]
change: [-2.2446% +6.0240% +19.339%] (p = 0.44 > 0.05)
transfer/pacing-false/varying-seeds: Change within noise threshold. time: [41.796 ms 41.887 ms 41.984 ms]
change: [+0.0886% +0.3967% +0.7111%] (p = 0.01 < 0.05)
transfer/pacing-true/varying-seeds: Change within noise threshold. time: [42.257 ms 42.345 ms 42.440 ms]
change: [+0.5231% +0.7759% +1.0599%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: No change in performance detected. time: [41.668 ms 41.744 ms 41.834 ms]
change: [-0.4145% -0.1776% +0.0949%] (p = 0.21 > 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [41.858 ms 41.924 ms 42.000 ms]
change: [-0.6614% -0.4225% -0.1639%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [873.70 ms 884.25 ms 895.06 ms]
thrpt: [111.72 MiB/s 113.09 MiB/s 114.46 MiB/s]
change:
time: [-1.8611% -0.2985% +1.3439%] (p = 0.72 > 0.05)
thrpt: [-1.3260% +0.2994% +1.8964%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [301.30 ms 303.66 ms 306.04 ms]
thrpt: [32.676 Kelem/s 32.931 Kelem/s 33.189 Kelem/s]
change:
time: [-0.6372% +0.4261% +1.4883%] (p = 0.44 > 0.05)
thrpt: [-1.4665% -0.4243% +0.6413%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.085 ms 34.261 ms 34.461 ms]
thrpt: [29.018 elem/s 29.188 elem/s 29.339 elem/s]
change:
time: [-0.9235% -0.1297% +0.6457%] (p = 0.75 > 0.05)
thrpt: [-0.6416% +0.1299% +0.9321%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: 💚 Performance has improved. time: [1.5976 s 1.6133 s 1.6289 s]
thrpt: [61.390 MiB/s 61.984 MiB/s 62.592 MiB/s]
change:
time: [-4.2338% -2.7700% -1.2673%] (p = 0.00 < 0.05)
thrpt: [+1.2836% +2.8489% +4.4210%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And deal with the fallout.