chore: Enable the clippy create_dir lint
#2315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2315 +/- ##
==========================================
+ Coverage 93.33% 93.35% +0.02%
==========================================
Files 114 114
Lines 36897 36897
Branches 36897 36897
==========================================
+ Hits 34436 34444 +8
+ Misses 1681 1671 -10
- Partials 780 782 +2 ☔ View full report in Codecov by Sentry. |
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to e5770ce. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.181 µs 11.227 µs 11.280 µs]
change: [+0.0054% +0.4169% +0.8655%] (p = 0.07 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0159 ms 3.0246 ms 3.0347 ms]
change: [-0.6028% -0.1324% +0.3181%] (p = 0.58 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.530 µs 19.636 µs 19.804 µs]
change: [-0.6313% +0.2415% +1.1269%] (p = 0.62 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1613 ms 5.1740 ms 5.1872 ms]
change: [-0.3973% -0.0422% +0.3220%] (p = 0.80 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5268 µs 5.5444 µs 5.5690 µs]
change: [-0.9437% -0.1671% +0.6363%] (p = 0.70 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7583 ms 1.7598 ms 1.7626 ms]
change: [-0.7007% -0.3106% +0.0164%] (p = 0.12 > 0.05)
coalesce_acked_from_zero 1+1 entries: Change within noise threshold. time: [99.473 ns 99.808 ns 100.15 ns]
change: [+0.3594% +0.8241% +1.3127%] (p = 0.00 < 0.05)
coalesce_acked_from_zero 3+1 entries: Change within noise threshold. time: [117.54 ns 117.95 ns 118.42 ns]
change: [+0.1027% +1.0478% +1.9003%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 10+1 entries: Change within noise threshold. time: [117.33 ns 117.89 ns 118.52 ns]
change: [+0.3238% +1.3009% +2.4059%] (p = 0.01 < 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [98.283 ns 98.440 ns 98.617 ns]
change: [-0.2940% +0.9427% +2.1644%] (p = 0.15 > 0.05)
RxStreamOrderer::inbound_frame(): No change in performance detected. time: [110.99 ms 111.06 ms 111.12 ms]
change: [-0.2463% -0.0393% +0.0962%] (p = 0.74 > 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4516 µs 5.5462 µs 5.6440 µs]
change: [-1.2144% +1.1369% +3.5303%] (p = 0.36 > 0.05)
transfer/pacing-false/varying-seeds: 💔 Performance has regressed. time: [44.697 ms 44.795 ms 44.897 ms]
change: [+7.0283% +7.3672% +7.6920%] (p = 0.00 < 0.05)
transfer/pacing-true/varying-seeds: 💔 Performance has regressed. time: [44.984 ms 45.069 ms 45.160 ms]
change: [+6.9966% +7.2587% +7.5519%] (p = 0.00 < 0.05)
transfer/pacing-false/same-seed: 💔 Performance has regressed. time: [44.718 ms 44.802 ms 44.901 ms]
change: [+6.8388% +7.1354% +7.4342%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: 💔 Performance has regressed. time: [44.806 ms 44.881 ms 44.969 ms]
change: [+6.3391% +6.6013% +6.8664%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [885.56 ms 895.83 ms 906.38 ms]
thrpt: [110.33 MiB/s 111.63 MiB/s 112.92 MiB/s]
change:
time: [-0.4958% +1.0068% +2.6376%] (p = 0.22 > 0.05)
thrpt: [-2.5699% -0.9968% +0.4982%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [299.55 ms 301.43 ms 303.35 ms]
thrpt: [32.965 Kelem/s 33.176 Kelem/s 33.384 Kelem/s]
change:
time: [-1.2504% -0.3132% +0.6623%] (p = 0.52 > 0.05)
thrpt: [-0.6580% +0.3142% +1.2663%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.335 ms 34.519 ms 34.721 ms]
thrpt: [28.801 elem/s 28.970 elem/s 29.125 elem/s]
change:
time: [-0.1566% +0.6216% +1.4234%] (p = 0.14 > 0.05)
thrpt: [-1.4034% -0.6178% +0.1569%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6144 s 1.6307 s 1.6470 s]
thrpt: [60.717 MiB/s 61.325 MiB/s 61.944 MiB/s]
change:
time: [-3.1543% -1.7252% -0.2434%] (p = 0.03 < 0.05)
thrpt: [+0.2440% +1.7555% +3.2570%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
mxinden
approved these changes
Jan 10, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Signed-off-by: Lars Eggert <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#create_dir