chore: Enable clippy clone_on_ref_ptr lint
#2314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larseggert
requested review from
KershawChang,
martinthomson and
mxinden
as code owners
Failed Interop TestsQUIC Interop Runner, client vs. server, differences relative to e5770ce. neqo-latest as client
neqo-latest as server
All resultsSucceeded Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
Unsupported Interop TestsQUIC Interop Runner, client vs. server neqo-latest as client
neqo-latest as server
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2314 +/- ##
=======================================
Coverage 93.32% 93.32%
=======================================
Files 114 114
Lines 36889 36897 +8
Branches 36889 36897 +8
=======================================
+ Hits 34427 34435 +8
Misses 1681 1681
Partials 781 781 ☔ View full report in Codecov by Sentry. |
Benchmark resultsPerformance differences relative to 6013bde. decode 4096 bytes, mask ff: No change in performance detected. time: [11.161 µs 11.204 µs 11.251 µs]
change: [-0.0339% +2.1587% +5.8826%] (p = 0.24 > 0.05)
decode 1048576 bytes, mask ff: No change in performance detected. time: [3.0183 ms 3.0281 ms 3.0393 ms]
change: [-0.4919% -0.0166% +0.5146%] (p = 0.95 > 0.05)
decode 4096 bytes, mask 7f: No change in performance detected. time: [19.548 µs 19.605 µs 19.667 µs]
change: [-0.7582% -0.0438% +0.5847%] (p = 0.91 > 0.05)
decode 1048576 bytes, mask 7f: No change in performance detected. time: [5.1610 ms 5.1727 ms 5.1858 ms]
change: [-0.4187% -0.0671% +0.2900%] (p = 0.72 > 0.05)
decode 4096 bytes, mask 3f: No change in performance detected. time: [5.5295 µs 5.5562 µs 5.5882 µs]
change: [-0.8557% -0.0011% +1.0724%] (p = 1.00 > 0.05)
decode 1048576 bytes, mask 3f: No change in performance detected. time: [1.7582 ms 1.7597 ms 1.7626 ms]
change: [-0.7049% -0.3137% +0.0100%] (p = 0.11 > 0.05)
coalesce_acked_from_zero 1+1 entries: No change in performance detected. time: [99.110 ns 99.430 ns 99.762 ns]
change: [+0.0065% +0.5828% +1.2031%] (p = 0.05 > 0.05)
coalesce_acked_from_zero 3+1 entries: No change in performance detected. time: [116.88 ns 117.25 ns 117.67 ns]
change: [-0.7014% +0.1855% +0.9074%] (p = 0.69 > 0.05)
coalesce_acked_from_zero 10+1 entries: No change in performance detected. time: [116.56 ns 116.98 ns 117.50 ns]
change: [-0.2147% +0.4822% +1.1834%] (p = 0.19 > 0.05)
coalesce_acked_from_zero 1000+1 entries: No change in performance detected. time: [97.772 ns 97.952 ns 98.173 ns]
change: [-0.6948% +0.5545% +1.8869%] (p = 0.41 > 0.05)
RxStreamOrderer::inbound_frame(): Change within noise threshold. time: [111.35 ms 111.40 ms 111.46 ms]
change: [+0.0704% +0.2726% +0.4030%] (p = 0.00 < 0.05)
SentPackets::take_ranges: No change in performance detected. time: [5.4797 µs 5.6289 µs 5.7784 µs]
change: [-3.0306% +4.7560% +17.884%] (p = 0.59 > 0.05)
transfer/pacing-false/varying-seeds: No change in performance detected. time: [41.640 ms 41.725 ms 41.814 ms]
change: [-0.2894% +0.0087% +0.3342%] (p = 0.95 > 0.05)
transfer/pacing-true/varying-seeds: No change in performance detected. time: [41.933 ms 42.020 ms 42.110 ms]
change: [-0.2708% +0.0020% +0.2851%] (p = 0.99 > 0.05)
transfer/pacing-false/same-seed: Change within noise threshold. time: [41.510 ms 41.577 ms 41.654 ms]
change: [-0.8286% -0.5762% -0.3153%] (p = 0.00 < 0.05)
transfer/pacing-true/same-seed: Change within noise threshold. time: [42.205 ms 42.271 ms 42.343 ms]
change: [+0.1580% +0.4012% +0.6414%] (p = 0.00 < 0.05)
1-conn/1-100mb-resp/mtu-1504 (aka. Download)/client: No change in performance detected. time: [878.55 ms 888.12 ms 898.01 ms]
thrpt: [111.36 MiB/s 112.60 MiB/s 113.82 MiB/s]
change:
time: [-1.3276% +0.1376% +1.7162%] (p = 0.86 > 0.05)
thrpt: [-1.6872% -0.1374% +1.3454%]
1-conn/10_000-parallel-1b-resp/mtu-1504 (aka. RPS)/client: No change in performance detected. time: [299.06 ms 301.30 ms 303.55 ms]
thrpt: [32.943 Kelem/s 33.189 Kelem/s 33.438 Kelem/s]
change:
time: [-1.3464% -0.3538% +0.6641%] (p = 0.50 > 0.05)
thrpt: [-0.6597% +0.3550% +1.3648%]
1-conn/1-1b-resp/mtu-1504 (aka. HPS)/client: No change in performance detected. time: [34.346 ms 34.574 ms 34.823 ms]
thrpt: [28.717 elem/s 28.923 elem/s 29.116 elem/s]
change:
time: [-0.1221% +0.7831% +1.6695%] (p = 0.09 > 0.05)
thrpt: [-1.6421% -0.7770% +0.1223%]
1-conn/1-100mb-resp/mtu-1504 (aka. Upload)/client: Change within noise threshold. time: [1.6000 s 1.6184 s 1.6370 s]
thrpt: [61.088 MiB/s 61.788 MiB/s 62.498 MiB/s]
change:
time: [-4.0187% -2.4621% -0.8721%] (p = 0.00 < 0.05)
thrpt: [+0.8798% +2.5242% +4.1870%]
Client/server transfer resultsTransfer of 33554432 bytes over loopback.
|
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
Signed-off-by: Lars Eggert <[email protected]>
mxinden
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_ref_ptr