Update flate2 and dependencies #3045
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This might unbreak builds on Rust 1.84.0
|
.. aaaand ... it doesn't. |
… always
This seems to be some recent regression, possibly in 1.84.0
Debug builds crash the iOS tests, specifically the `testPendingDeletionRequestPingsAreSentOnStartup` test with a real hard crash:
Thread 2: EXC_BAD_ACCESS (code=2, address=0x16d3ebfb0)
pointing deep inside `library/alloc/src/boxed.rs` here: https://github.com/rust-lang/rust/blob/3ff1b6410e87a237559ab76ecd50f180afbe861f/library/alloc/src/boxed.rs#L1733
Tracing that upwards leads us to `Box::default()` in miniz_oxide, were T
is a struct containing 3 arrays, with a total size of 164098.
I can only assume that this somehow blows the stack.
Why now? I don't know. We had a successful CI run on 29e1722,
followed by failures starting with c46917a.
From my quick look that's the exact same environment: xcode:15.1.0, rustc 1.84.0
Yet it fails on CI. And locally.
rustc 1.83 is fine. So is a release build.
travis79
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might unbreak builds on Rust 1.84.0
Which is a bit weird, but ... eh.