Bug 1822482 - Switch from chrono to time 0.3 #2429
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a frist try at migrating from chrono to time.
This compiles, but with warnings.
Tests don't compile, as they still largely make use of chrono.
Things that would need to be tested:
* Do we handle timezones correctly?
* Are we handling time measurement correctly?
* This switched from `time::precise_time_ns()` to libstd's `Instant`.
We need to verify the guarantees.
* Are we correctly (de)serializing data?
* Datetimes are stored in the database. We need to handle the old data
transparently. `DatetimeWrapper` should do that, but will require
more testing.
* Truncation/Formatting
* We use `TimeUnit` for the date/time related metrics to truncate.
As this switches formatting we need to verify it's correct
(especially at the nano-/micro-/millisecond level)
FWIW, I looked into this last week or the week before, and libstd has the same, or better, precision. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a first try at migrating from chrono to time. This compiles, but with warnings.
Tests don't compile, as they still largely make use of chrono.
Things that would need to be tested:
time::precise_time_ns()to libstd'sInstant. We need to verify the guarantees.DatetimeWrappershould do that, but will require more testing.TimeUnitfor the date/time related metrics to truncate. As this switches formatting we need to verify it's correct (especially at the nano-/micro-/millisecond level)