Bug 1771169 - Swift: Separate endpoints for tests #2121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is trying to deploy an idea @travis79 had: Use test-specific endpoints so that different tests don't share endpoints. In theory then no requests will ever overlap and we wouldn't need to deal with overdue ping uploads in subsequent tests.
However this still fails occasionally for me with hard crashes, so it's definitely far from done.
Maybe something more like I did for Android could work: a way to hook into the lifecylce (#2116) so that in tests we can wait for the right things?
Creating a draft PR, so that I can delegate this maybe.