Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dev-launcher) - Change the default context to oauth_webchannel_v1 #18257

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

jonalmeida
Copy link
Contributor

Because

  • This is the default flow that we use in desktop today, but we can't remove the old flow until ESR is updated to v140+.

This pull request

  • Changes the default context to use the Firefox browser default OAuth flow.

Issue that this pull request solves

Closes: Fixes FXA-9872

Checklist

Put an x in the boxes that apply

  • My commit is GPG signed.
  • If applicable, I have modified or added tests which pass locally.
  • I have added necessary documentation (if appropriate).
  • I have verified that my changes render correctly in RTL (if appropriate).

Screenshots (Optional)

n/a

Other information (Optional)

From this comment in JIRA:
Following up on #17274, we might want to take this opportunity to clean up the profile for dev-launcher. A lot of the custom configuration might not be needed anymore with the addition of the autoConfig setting.

We still need to support the older flow until the next ESR version (v140), so I don't recommend removing or cleaning up the previous one until the June release.

@jonalmeida jonalmeida requested a review from a team as a code owner January 21, 2025 16:52
@LZoog
Copy link
Contributor

LZoog commented Jan 22, 2025

We still need to support the older flow until the next ESR version (v140), so I don't recommend removing or cleaning up the previous one until the June release.

@jonalmeida this is just calling out that we don't need all those CONFIGS. I think all we need is identity.fxaccounts.autoconfig.uri?

@jonalmeida
Copy link
Contributor Author

@LZoog funny enough that in bug 1942925, it was dev-launcher settings those prefs that helped verify that the autoconfig pref wasn't working correctly. 😄

I can remove them too if you feel strongly.

@LZoog
Copy link
Contributor

LZoog commented Jan 22, 2025

@jonalmeida if it helped debug something, I say leave it! Maybe we add a comment somewhere noting that?

@jonalmeida
Copy link
Contributor Author

if it helped debug something, I say leave it! Maybe we add a comment somewhere noting that?

Will do before landing!

Thanks @vbudhram for approving - sorry, I didn't see that earlier!

This is the default flow that we use in desktop today, but we can't
remove the old flow until ESR is updated to v140+.

Fixes FXA-9872
@jonalmeida jonalmeida merged commit b291d3a into main Jan 23, 2025
4 of 5 checks passed
@jonalmeida jonalmeida deleted the FXA-9872 branch January 23, 2025 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants