Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[perfalert_inactive_regression] Don't needinfo on bugs with a pending needinfo and don't comment more than once #2576

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

suhaibmujahid
Copy link
Member

Fixes #2575

@gmierz WDYT?

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid requested a review from marco-c January 22, 2025 13:17
@gmierz
Copy link
Contributor

gmierz commented Jan 22, 2025

I'm not okay with that change. We're using those comments/needinfos to keep track of bugs that have no activity happening on them. I'm okay with it not doing a needinfo if there's already a needinfo for the author, as long as the comment is still made and we get it in the bugmail. In the next couple months, we're planning on starting to request backouts for patches that have two consecutive requests for updates with no activity. Just gathering data atm about how often it happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The perfalert_inactive_regression rule shouldn't be adding more than one needinfo
3 participants