[New Rule] Needinfo when a bug is pending sec-approval but not all tracking flags are set

bugbot/rules/pending_sec_no_tracking.py

@@ -0,0 +1,86 @@
+# This Source Code Form is subject to the terms of the Mozilla Public
+# License, v. 2.0. If a copy of the MPL was not distributed with this file,
+# You can obtain one at http://mozilla.org/MPL/2.0/.
+
+
+from bugbot import utils
+from bugbot.bzcleaner import BzCleaner
+
+
+class SecurityApprovalTracking(BzCleaner):
+    def __init__(self, channel):
+        super().__init__()
+        self.channel = channel
+        if not self.init_versions():
+            return
+
+        self.version = self.versions[channel] if self.versions else None
+
+        self.extra_ni = None
+
+    def description(self):
+        return "Bugs with attachments pending security approval and incomplete tracking flags"
+
+    def handle_bug(self, bug, data):
+        # Assuming these bugs are bugs that do not have a status flag set to either "affected" or "unaffected"
+        bugid = str(bug["id"])
+        data[bugid] = {
+            "id": bugid,
+            "summary": bug["summary"],
+            "assignee": bug["assigned_to"],
+        }
+        self.add_auto_ni(
+            bugid,
+            {"mail": bug["assigned_to"], "nickname": bug["assigned_to_detail"]["nick"]},
+        )
+
+        return bug
+
+    def get_extra_for_needinfo_template(self):
+        return self.extra_ni
+
+    def columns(self):
+        return ["id", "summary", "assignee"]
+
+    def get_bz_params(self, date):
+        start_date, _ = self.get_dates(date)
+
+        status = utils.get_flag(self.version, "status", self.channel)
+        fields = [
+            "id",
+            "assigned_to",
+            "nickname",
+            "flags",
+        ]
+
+        params = {
+            "include_fields": fields,
+            "resolution": "---",
+            "f1": "creation_ts",
+            "o1": "greaterthan",
+            "v1": start_date,
+            "f2": status,
+            "o2": "anywords",
+            "n2": "1",
+            "v2": ",".join(["unaffected", "affected"]),
+            "f3": "flagtypes.name",
+            "o3": "substring",
+            "v3": "sec-approval?",
+            "f4": "cf_status_firefox_nightly",
+            "o4": "equals",
+            "v4": "---",
+            "f5": "cf_status_firefox_beta",
+            "o5": "equals",
+            "v5": "---",
+            "f6": "cf_status_firefox_release",
+            "o6": "equals",
+            "v6": "---",
+        }
+
+        return params
+
+
+if __name__ == "__main__":
+    SecurityApprovalTracking("beta").run()
+    SecurityApprovalTracking("central").run()
+    SecurityApprovalTracking("esr").run()

templates/pending_sec_no_tracking.html

@@ -0,0 +1,23 @@
+<p>
+    The following {{ plural('bug has', data, pword='bugs have') }} a patch pending security approval, but the affected/unaffected status is not set for all current releases:
+</p>
+<table {{ table_attrs }}>
+    <thead>
+        <tr>
+            <th>Bug</th>
+            <th>Summary</th>
+        </tr>
+    </thead>
+    <tbody>
+        {% for i, (id, summary, assignee) in enumerate(data) -%}
+            <tr {% if i % 2 == 0 %}bgcolor="#E0E0E0"
+            {% endif -%}
+            >
+            <td>
+                <a href="https://bugzilla.mozilla.org/show_bug.cgi?id={{ id }}">{{ id }}</a>
+            </td>
+            <td>{{ summary | e }}</td>
+        </tr>
+    {% endfor -%}
+</tbody>
+</table>

templates/pending_sec_no_tracking_needinfo.txt

@@ -0,0 +1 @@
+:{{ nickname }}, there is a patch pending security approval, however, the affected/unaffected status is not set for all current releases. Please update the status flags to correctly reflect the correct status.