Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a bugscore report #2331

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
144 changes: 144 additions & 0 deletions bugbot/rules/bugscore.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,144 @@
# This Source Code Form is subject to the terms of the Mozilla Public
# License, v. 2.0. If a copy of the MPL was not distributed with this file,
# You can obtain one at http://mozilla.org/MPL/2.0/.

from bugbot import utils
from bugbot.bzcleaner import BzCleaner


class BugScore(BzCleaner):
def __init__(self):
super(BugScore, self).__init__()
self.ndups = self.get_config("number_dups")
self.votes = self.get_config("number_votes")
self.cc = self.get_config("number_cc")
self.see_also = self.get_config("number_see_also")
self.comments = self.get_config("number_comments")
Comment on lines +12 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use the constructor parameters to configure the rules instead of the config file (see #1437)?

Alternatively, you could assign the values directly, just like the weights, without using the configuration file.

Comment on lines +12 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could unify the variable naming in a descriptive way (e.g., min_comments or num_comments_threshold)

Comment on lines +12 to +16
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: It could be useful to add a comment to clarify that these thresholds are to highlight the values in the table, not to be used in the query.


# Weights for each category
self.votes_weight = 0.5
self.see_also_weight = 0.8
self.dups_weight = 1.0
self.comments_weight = 0.4
self.ccs_weight = 0.3
self.threshold = 20

self.extra_ni = {}

def description(self):
return "Bugs scores"

def sort_columns(self):
return lambda p: (-p[9], -int(p[0]))

def columns(self):
return [
"id",
"summary",
"creation",
"last_change",
"severity",
"dups_count",
"votes",
"cc_count",
"see_also_count",
"user_impact_score",
"comment_count",
"product",
"component",
"type",
]

def get_extra_for_template(self):
return {
"dups_threshold": self.ndups,
"votes_threshold": self.votes,
"cc_threshold": self.cc,
"see_also_threshold": self.see_also,
"comments_threshold": self.comments,
"votes_weight": self.votes_weight,
"see_also_weight": self.see_also_weight,
"dups_weight": self.dups_weight,
"comments_weight": self.comments_weight,
"ccs_weight": self.ccs_weight,
"threshold": self.threshold,
}

def handle_bug(self, bug, data):
bugid = str(bug["id"])
cc_count = len(bug["cc"])
dups_count = len(bug["duplicates"])
votes_count = bug["votes"]
see_also_count = len(bug["see_also"])
comment_count = bug["comment_count"]

# Calculating the User Impact Score
user_impact_score = round(
(votes_count * self.votes_weight)
+ (see_also_count * self.see_also_weight)
+ (dups_count * self.dups_weight)
+ (comment_count * self.comments_weight)
+ (cc_count * self.ccs_weight)
)
if user_impact_score < self.threshold:
return
data[bugid] = {
"creation": utils.get_human_lag(bug["creation_time"]),
"last_change": utils.get_human_lag(bug["last_change_time"]),
"severity": bug["severity"],
"dups_count": dups_count,
"votes": votes_count,
"cc_count": cc_count,
"see_also_count": see_also_count,
"user_impact_score": user_impact_score,
"comment_count": comment_count,
"product": bug["product"],
"component": bug["component"],
"type": bug["type"],
}

return bug

def get_bz_params(self, date):
fields = [
"creation_time",
"last_change_time",
"severity",
"votes",
"cc",
"duplicates",
"see_also",
"comment_count",
"product",
"component",
"type",
]

params = {
"include_fields": fields,
"resolution": "---",
"f1": "keywords",
"o1": "nowords",
"v1": ["meta", "intermittent"],
"j3": "OR",
"f3": "OP",
"f4": "dupe_count",
"o4": "greaterthaneq",
"v4": "5",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Declaring these thresholds in the constructor after the highlighting thresholds will help distinguish between the two types of thresholds.

"f5": "votes",
"o5": "greaterthaneq",
"v5": "10",
"f6": "cc_count",
"o6": "greaterthaneq",
"v6": "20",
"f7": "see_also_count",
"o7": "greaterthaneq",
"v7": "2",
"f8": "CP",
}

return params


if __name__ == "__main__":
BugScore().run()
9 changes: 9 additions & 0 deletions configs/rules.json
Original file line number Diff line number Diff line change
Expand Up @@ -466,5 +466,14 @@
"leave_open_sec": {
"additional_receivers": "rm",
"days_lookup": 2
},
"bugscore": {
"number_dups": 30,
"number_votes": 200,
"number_cc": 100,
"number_see_also": 10,
"number_comments": 150,
"additional_receivers": "rm",
"must_run": ["Mon"]
}
}
1 change: 1 addition & 0 deletions scripts/check_rules_on_wiki.py
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ class CheckWikiPage:
"pdfjs_tag_change.py",
"pdfjs_update.py",
"leave_open_sec.py",
"bugscore.py"
}

def __init__(self) -> None:
Expand Down
3 changes: 3 additions & 0 deletions scripts/cron_run_weekdays.sh
Original file line number Diff line number Diff line change
Expand Up @@ -88,6 +88,9 @@ python -m bugbot.rules.several_comments --production
# Bugs with a lot of see also
python -m bugbot.rules.several_see_also --production

# List of papercuts
python -m bugbot.rules.bugscore --production

# Bug caused several regressions recently reported
# Pretty rare
python -m bugbot.rules.warn_regressed_by --production
Expand Down
Loading