Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no_severity] Fix the query to exclude bugs that recently changed components #1718

Merged
merged 2 commits into from
Oct 29, 2022

Conversation

suhaibmujahid
Copy link
Member

Fixes #1250

The query:

The query is very long. I think it would be clearer to do the "component change" filtering on the client side. It would be ideal to do this refactoring as part of #1551. @marco-c wdyt?

Checklist

  • Type annotations added to new functions
  • Docs added to functions touched in main classes
  • Dry-run produced the expected results
  • The to-be-announced tag added if this is worth announcing

@suhaibmujahid suhaibmujahid requested a review from marco-c October 28, 2022 21:37
@marco-c
Copy link
Contributor

marco-c commented Oct 28, 2022

The query is very long. I think it would be clearer to do the "component change" filtering on the client side. It would be ideal to do this refactoring as part of #1551. @marco-c wdyt?

Yes, this is pretty hard to review!

@suhaibmujahid
Copy link
Member Author

suhaibmujahid commented Oct 28, 2022

Yes, this is pretty hard to review!

Changing the numbers makes the diff messy. Below is a visualization of the diff:

Before

Screen Shot 2022-10-28 at 7 39 33 PM

After

Screen Shot 2022-10-28 at 7 39 15 PM

Copy link
Contributor

@marco-c marco-c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the image makes it much easier.

@suhaibmujahid suhaibmujahid merged commit 951ab6b into mozilla:master Oct 29, 2022
@suhaibmujahid suhaibmujahid deleted the no-severity-component branch October 29, 2022 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants