WNP135 for North America (#15852) #15876
Open
+152
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maureenlholland
commented
Jan 15, 2025
| <section class="wnp-content-main mzp-l-content mzp-t-content-md"> | ||
| <h1 class="wnp-main-title"> | ||
| {{ picture( | ||
| url="img/firefox/whatsnew/whatsnew135-pdf/edit-pdfs-light.svg", |
There was a problem hiding this comment.
new image paths
maureenlholland
commented
Jan 15, 2025
| {% extends "firefox/whatsnew/base.html" %} | ||
|
|
||
| {% block page_css %} | ||
| {{ css_bundle('firefox_whatsnew_135_pdf') }} |
There was a problem hiding this comment.
new css paths (js removed)
maureenlholland
commented
Jan 15, 2025
|
|
||
| <div class="wnp-editor"> | ||
| <p class="wnp-main-tagline"> | ||
| Say goodbye to the hassle of printing or filling out PDFs in other apps. Quickly and easily edit documents right in your browser. |
There was a problem hiding this comment.
updated text
maureenlholland
force-pushed
the
wnp-135
branch
from
5357130 to
3dce96a
Compare
janbrasna
reviewed
Jan 16, 2025
maureenlholland
force-pushed
the
wnp-135
branch
from
3dce96a to
0ea50b8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15876 +/- ##
=======================================
Coverage 79.29% 79.30%
=======================================
Files 159 159
Lines 8347 8349 +2
=======================================
+ Hits 6619 6621 +2
Misses 1728 1728 ☔ View full report in Codecov by Sentry. |
8 tasks
maureenlholland
added
Blocked
and removed
WIP 🚧
|
blocked until we have confirmation on the PDF asset UPDATE: we want to update the PDF asset, need to upload it with a new name to bust the cache |
maureenlholland
force-pushed
the
wnp-135
branch
from
0ea50b8 to
1ea070d
Compare
This was carried over from preview WNP, but is not needed in this iteration
maureenlholland
force-pushed
the
wnp-135
branch
from
f1fca70 to
e85021f
Compare
maureenlholland
added
Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
Restores PDF WNP from 111/124 to use for North American WNP135
Significant changes and points to review
WNP124 code restored based on this PR: https://github.com/mozilla/bedrock/pull/14670/files#diff-a868bb4b9a053f005284e94867e14178c64414266d0c8a31c849843461a14b3a
Issue / Bugzilla link
#15852
Testing
http://localhost:8000/en-US/firefox/135.0/whatsnew/