Promote CSP frame-ancestors directive
#15768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15768 +/- ##
=======================================
Coverage 79.07% 79.07%
=======================================
Files 160 160
Lines 8359 8359
=======================================
Hits 6610 6610
Misses 1749 1749 ☔ View full report in Codecov by Sentry. |
janbrasna
reviewed
Dec 17, 2024
janbrasna
reviewed
Dec 17, 2024
stevejalim
approved these changes
Dec 19, 2024
robhudson
force-pushed
the
frame-ancestors-enforced
branch
from
27f2a00 to
065e0f3
Compare
robhudson
force-pushed
the
frame-ancestors-enforced
branch
from
065e0f3 to
28a43f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One-line summary
The
frame-ancestors: 'none'directive prevents the site from being embedded in any<iframe>,<object>, or<embed>elements, mitigating clickjacking attacks.This directive has been running in report-only mode, generating reports without enforcing the policy. The reports show no valid embedding attempts, confirming that the directive will protect the website without breaking any legitimate use cases.
Issue / Bugzilla link
#11943
Testing