Bugfix FXIOS-9699 [webcompat] Force mobile UA for PayPal (backport #24497) #24637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
4 tasks
yoanarios
approved these changes
Feb 7, 2025
| @@ -104,12 +104,11 @@ struct CustomUserAgentConstant { | |||
| private static let customDesktopUA = UserAgentBuilder.defaultDesktopUserAgent().clone(extensions: "Version/\(AppInfo.appVersion) \(UserAgent.uaBitSafari)") | |||
|
|
|||
| static let customMobileUAForDomain = [ | |||
| "paypal.com": defaultMobileUA, | |||
| "yahoo.com": defaultMobileUA, | |||
There was a problem hiding this comment.
OOC why was yahoo.com removed also?
There was a problem hiding this comment.
For both cases, they were returning defaultMobileUA which is the default for mobile so there was no need to list them as a customMobileUAForDomain. I added unit test in my other PR to cover Paypal for Mobile and DesktopUA
There was a problem hiding this comment.
👍 Thanks @yoanarios
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira tickets: FXIOS-8027 (FXIOS-11230), FXIOS-9699
Github issues: #17911 (#24431), #21314
💡 Description
This moves the UAstring override for PayPal.com from the mobile section (where it defaults to the default anyways) to the desktop section, which correlates with the default setting for iPads; where most of the issues occur.
(Also: removes the default for yahoo.com, that also sends just default…)
NB: This is not a real fix of the underlying issue #17911 (comment) (as PayPal explicitly states that it should not be used from within WebViews, so whenever they insist on opening a popup the bug would demonstrate again) — this is just signaling them a mobile device, to open the widget in the same frame/tab, thus avoiding the about:blank breakage.
(In other words, getting desktop mode behavior for PayPal checkout buttons on par with with mobile mode, where issues are not being reported, for consistency.)
📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)This is an automatic backport of pull request #24497 done by [Mergify](https://mergify.com).