Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove FXIOS [Dead code] Remove generated file WebcompatAllFramesAtDocumentStart.js from Git index #24496

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Remove FXIOS [Dead code] Remove generated file WebcompatAllFramesAtDocumentStart.js from Git index #24496

merged 1 commit into from
Feb 3, 2025

Conversation

issammani
Copy link
Collaborator

📜 Tickets

No tickets

💡 Description

WebcompatAllFramesAtDocumentStart.js is generated during every build using Webpack. It does not need to be committed to Git.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@issammani issammani requested a review from a team as a code owner February 1, 2025 18:13
@issammani issammani requested a review from Cramsden February 1, 2025 18:13
@issammani issammani merged commit 9c72af4 into main Feb 3, 2025
10 checks passed
@issammani issammani deleted the chore/untrack-webcompat-script branch February 3, 2025 15:34
aya-en-amir pushed a commit to aya-en-amir/firefox-ios that referenced this pull request Feb 5, 2025
@issammani @aya-en-amir
Remove FXIOS [Dead code] Remove generated file `WebcompatAllFramesAtD…
98561d9 
…ocumentStart.js` from Git index (mozilla-mobile#24496)

chore: remove generated WebcompatAllFramesAtDocumentStart.js from git index
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cramsden Cramsden Cramsden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@issammani @Cramsden