Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace FXIOS-11247 Replace usage of UIColor.Photon.White100 #24479

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Replace FXIOS-11247 Replace usage of UIColor.Photon.White100 #24479

merged 1 commit into from
Feb 3, 2025

Conversation

yusuphjoluwasen
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Replace usage of UIColor.Photon.White100
  • Remove UIColor.Photon.White100 in photon-colors

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@yusuphjoluwasen yusuphjoluwasen requested a review from a team as a code owner January 31, 2025 12:12
FilippoZazzeroni
FilippoZazzeroni approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@FilippoZazzeroni FilippoZazzeroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 🎉

@FilippoZazzeroni FilippoZazzeroni changed the title Replace FXIOS-24460 Replace usage of UIColor.Photon.White100 Replace FXIOS-11247 Replace usage of UIColor.Photon.White100 Feb 3, 2025
@FilippoZazzeroni FilippoZazzeroni merged commit 0caa319 into mozilla-mobile:main Feb 3, 2025
10 checks passed
aya-en-amir pushed a commit to aya-en-amir/firefox-ios that referenced this pull request Feb 5, 2025
@yusuphjoluwasen @aya-en-amir
Replace FXIOS-11247 Replace usage of UIColor.Photon.White100 (mozilla…
5042bc3 
…-mobile#24479)

replace usage of UIColor.Photon.White100 with UIColor.white
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FilippoZazzeroni FilippoZazzeroni FilippoZazzeroni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yusuphjoluwasen @FilippoZazzeroni