Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FXIOS-11248 Remove usage of UIColor.Photon.Grey60 #24478

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bmihai23
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

  • Removed photon color Grey60

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed, I updated documentation / comments for complex code and public methods
  • If needed, added a backport comment (example @Mergifyio backport release/v120)

@bmihai23 bmihai23 requested a review from a team as a code owner January 31, 2025 10:02
@bmihai23 bmihai23 requested a review from dataports January 31, 2025 10:02
Copy link
Contributor

@lmarceau lmarceau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! The class func replace(_ base: String, keys: [String], replacements: [String]) -> NSMutableAttributedString isn't called anymore. We can remove it from the code I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants