Refactor FXIOS-11147 [Tabs] Remove Legacy Tab Manager Part 1 #24436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Client.app: Coverage: 32.34
Generated by 🚫 Danger Swift against 8564de7 |
|
Making this a draft PR. I need to fix some more tests |
OrlaM
approved these changes
Jan 31, 2025
yoanarios
approved these changes
Feb 3, 2025
firefox-ios/Client/TabManagement/TabManagerImplementation.swift
Outdated
Show resolved
Hide resolved
ih-codes
approved these changes
Feb 3, 2025
Comment on lines
-155
to
-168
| func testRemoveScreenshotWithImage() async throws { | ||
| let subject = createSubject() | ||
| addTabs(to: subject, count: 5) | ||
| guard let tab = subject.tabs.first else { | ||
| XCTFail("First tab was expected to be found") | ||
| return | ||
| } | ||
|
|
||
| tab.setScreenshot(UIImage()) | ||
| await subject.removeScreenshot(tab: tab) | ||
| try await Task.sleep(nanoseconds: sleepTime) | ||
| XCTAssertEqual(mockDiskImageStore.deleteImageForKeyCallCount, 1) | ||
| } | ||
|
|
There was a problem hiding this comment.
I take it this test was no longer useful..?
There was a problem hiding this comment.
It appeared to be testing the same functionality as testSaveScreenshotWithImage since tabDidSetScreenshot calls removeScreenshot when a previous screenshot is set.
aya-en-amir
pushed a commit
to aya-en-amir/firefox-ios
that referenced
this pull request
Feb 5, 2025
…-mobile#24436) * V1 - remove legacy tab manager and move existing functionality into tab manager * reorder * fix linting error * clean up * Rename TabManagerDelegate and move out of Legacy code * clean up todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Tickets
Jira ticket
Github issue
💡 Description
We no longer need the
LegacyTabMangernow that we have finished the Tab Tray refactor. The way that things are currently architected, there is still a lot of logic inLegacyTabManagerthat needed to be moved in toTabManagerImplmentation. This is part 1 of clean up to theTabManager📝 Checklist
You have to check all boxes before merging
@Mergifyio backport release/v120)