Updates from bedrock #404
Updates from bedrock #404
Conversation
From file changes in mozilla/bedrock@5f44a96
|
|
||
| home-mozilla-takes-bets = “{ -brand-name-mozilla } is taking bets to show the world there’s a business to be made with trustworthy AI. That includes putting things like human rights, data protection and transparency at the core of how these complex systems work.” | ||
|
|
||
| # Politico is a brand name for a news organization | ||
| home-politico-cite = Politico | ||
|
|
||
| home-join-us-in-shaping = Join us in shaping trustworthy AI | ||
| home-work-on-ai = { -brand-name-mozilla }’s work with AI isn’t just a new thing—we’ve spent years funding, building and advocating for AI that’s open, fair and developed responsibly. Our focus is on creating AI that serves the people, prioritizes transparency and supports the public good, not corporate agendas. |
There was a problem hiding this comment.
This:
"work with AI isn’t just a new thing—we’ve spent years funding"
already is U+2014 EM DASH
@peiying2 Do you mean another occurence?
There was a problem hiding this comment.
The only inconsistent thing here is that while this sentence uses the dash correctly — without the spaces on both sides (at it should be IIRC), the other string on L64 has spaces around it. So the only thing I see here wrt dashes would be making these two occurrences more consistent: mozilla/bedrock#14602 (comment)
There was a problem hiding this comment.
OTOH the "correct" (non)spacing produces some ugly line breaks at times:
so the question is whether to give up and just have spaces around it?
There was a problem hiding this comment.
I've asked the copy writing team for clarification on spaces and em dashes. It seems we are doing it a couple different ways currently and since we are trying to go a little more colloquial with our tone, that might be true of our grammar too so I don't feel confident making a call myself.
There was a problem hiding this comment.
Oh, it was hard to see it. I agree with @janbrasna that there should be a space before and after the M dash, but it has been inconsistent throughout. If there is a branding or style guide somewhere, let me know. For now, I will take this as is and move forward.
There was a problem hiding this comment.
I talked to someone in brand and they said spaces around the dash are the way to go.
They also said they don't have a style guide.
| @@ -57,3 +83,9 @@ home-featured-product = Featured product | |||
|
|
|||
| # HTML for visual formatting. "Blur" here is used as a metaphor for hiding or obscuring something. | |||
| home-feature-blur-your-location = Blur your location & activity using <span>{ -brand-name-mozilla-vpn }</span> | |||
|
|
|||
There was a problem hiding this comment.
remove an extra line break
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
en/navigation_v2.ftl
Outdated
| navigation-v2-mozilla-ai = { -brand-name-mozilla-ai } | ||
|
|
||
| navigation-v2-mozilla-ventures = { -brand-name-mozilla-ventures } |
There was a problem hiding this comment.
I wonder whether these two should be removed for now as not to surprise anyone — the menu items were not actually added in the end.
There was a problem hiding this comment.
@stephaniehobson who can make this decision? Should we keep them and they will show up eventually?
There was a problem hiding this comment.
For now, it doesn't seem like they're going to be added to the nav anytime soon, so I'm going to remove them from our codebase for now. Thanks for the call-out @janbrasna !
From file changes in mozilla/bedrock@3489c49
From file changes in mozilla/bedrock@9362016
From file changes in mozilla/bedrock@5f44a96