Skip to content

Commit

Permalink
Bump versions for GHA modules and unittests
Browse files Browse the repository at this point in the history
  • Loading branch information
dividehex committed Jun 18, 2024
1 parent f3cc802 commit e31fad7
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 11 deletions.
10 changes: 5 additions & 5 deletions .github/workflows/google-deploy.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,17 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: 'Checkout'
uses: 'actions/checkout@v3'
uses: 'actions/checkout@v4'

- name: 'Google auth'
id: 'auth'
uses: 'google-github-actions/auth@v1'
uses: 'google-github-actions/auth@v2'
with:
workload_identity_provider: '${{ secrets.WIF_PROVIDER }}'
service_account: '${{ secrets.WIF_SERVICE_ACCOUNT }}'

- name: Send initial slack notification
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
id: slack
with:
channel-id: ${{ env.CHANNEL_IDS }}
Expand Down Expand Up @@ -61,7 +61,7 @@ jobs:

- name: Update slack deployment complete
if: success()
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
with:
update-ts: ${{ steps.slack.outputs.ts }}
channel-id: ${{ env.CHANNEL_IDS }}
Expand All @@ -73,7 +73,7 @@ jobs:

- name: Update slack deployment failed
if: failure()
uses: slackapi/slack-github-action@v1.24.0
uses: slackapi/slack-github-action@v1.26.0
with:
update-ts: ${{ steps.slack.outputs.ts }}
channel-id: ${{ env.CHANNEL_IDS }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/tests.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,11 @@ jobs:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v4
- name: Set up Python
uses: actions/setup-python@v4
uses: actions/setup-python@v5
with:
python-version: 3.7
python-version: 3.12
- name: Run tests via Makefile
run: |
make test
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ S3_BUCKET := ${S3_BUCKET}

.PHONY: test
test:
pip install pyyaml==5.4.1
pip install pyyaml==6.0.1
python -m unittest discover tests

.PHONY: deploy
Expand Down
4 changes: 2 additions & 2 deletions tests/test_yaml.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,11 +19,11 @@ def test_output_exists(self):
assert self.get_yaml_file() is not None

def test_yaml_loads(self):
yaml_content = yaml.load(self.get_yaml_file())
yaml_content = yaml.load(self.get_yaml_file(), Loader=yaml.SafeLoader)
assert yaml_content is not None

def test_each_has_required_keys(self):
yaml_content = yaml.load(self.get_yaml_file())
yaml_content = yaml.load(self.get_yaml_file(), Loader=yaml.SafeLoader)
assert yaml_content is not None

for app in yaml_content['apps']:
Expand Down

0 comments on commit e31fad7

Please sign in to comment.