Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: linter check submodules #601

Merged
merged 37 commits into from
May 26, 2022
Merged

ci: linter check submodules #601

merged 37 commits into from
May 26, 2022

Conversation

seeflood
Copy link
Member

@seeflood seeflood commented May 23, 2022

Signed-off-by: seeflood [email protected]

What this PR does:
The linter will check submodules:
image

image

I followed the solution in golangci/golangci-lint#828 (comment)

todo list:

Future work:

  • make script can check submodules

Which issue(s) this PR fixes:

Fixes #598

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Signed-off-by: seeflood <[email protected]>
@seeflood seeflood changed the title [WIP]ci: linter support submodules [WIP]ci: linter check submodules May 24, 2022
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood changed the title [WIP]ci: linter check submodules ci: linter check submodules May 24, 2022
@seeflood seeflood requested review from a team May 24, 2022 12:21
@codecov
Copy link

codecov bot commented May 24, 2022

Codecov Report

Merging #601 (a90a04e) into main (7a2eefd) will increase coverage by 0.18%.
The diff coverage is 35.78%.

❗ Current head a90a04e differs from pull request most recent head 3dd28a8. Consider uploading reports for the commit 3dd28a8 to get more accurate results

@@            Coverage Diff             @@
##             main     #601      +/-   ##
==========================================
+ Coverage   60.73%   60.92%   +0.18%     
==========================================
  Files         120      120              
  Lines        6375     6377       +2     
==========================================
+ Hits         3872     3885      +13     
+ Misses       2133     2120      -13     
- Partials      370      372       +2     
Impacted Files Coverage Δ
components/configstores/apollo/repository.go 12.12% <0.00%> (+0.69%) ⬆️
components/configstores/etcdv3/etcdv3.go 81.20% <0.00%> (ø)
components/file/hdfs/hdfs.go 46.15% <0.00%> (ø)
components/file/s3/aws/oss.go 29.53% <ø> (ø)
components/pkg/utils/etcd.go 12.69% <0.00%> (ø)
components/pkg/utils/mongo.go 0.00% <0.00%> (ø)
components/pkg/utils/redis.go 0.00% <0.00%> (ø)
components/rpc/invoker/mosn/channel/httpchannel.go 69.89% <ø> (ø)
components/rpc/invoker/mosn/mosninvoker.go 65.00% <ø> (ø)
sdk/go-sdk/client/client.go 93.33% <ø> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a2eefd...3dd28a8. Read the comment docs.

Signed-off-by: seeflood <[email protected]>
@seeflood seeflood mentioned this pull request May 24, 2022
25 tasks
seeflood added 4 commits May 25, 2022 11:41
# Conflicts:
#	demo/file/client.go
#	demo/file/stressmem.go
#	demo/go.mod
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
@seeflood seeflood requested a review from Xunzhuo May 25, 2022 09:57
Copy link
Member

@Xunzhuo Xunzhuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: make check.lint should check different go modules 让make脚本检查不同的 go 模块
3 participants