-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: linter check submodules #601
Conversation
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
# Conflicts: # sdk/go-sdk/client/secret.go
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #601 +/- ##
==========================================
+ Coverage 60.73% 60.92% +0.18%
==========================================
Files 120 120
Lines 6375 6377 +2
==========================================
+ Hits 3872 3885 +13
+ Misses 2133 2120 -13
- Partials 370 372 +2
Continue to review full report at Codecov.
|
Signed-off-by: seeflood <[email protected]>
# Conflicts: # demo/file/client.go # demo/file/stressmem.go # demo/go.mod
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
Signed-off-by: seeflood <[email protected]>
This reverts commit febc306 Signed-off-by: seeflood <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: seeflood [email protected]
What this PR does:
The linter will check submodules:
I followed the solution in golangci/golangci-lint#828 (comment)
todo list:
I solved it using the workaround in github action log output doesn't print the affected file name & line golangci/golangci-lint-action#119 (comment)
Future work:
make
script can check submodulesWhich issue(s) this PR fixes:
Fixes #598
Special notes for your reviewer:
Does this PR introduce a user-facing change?: